Examples: Adopt structure used in the Vapor template repository #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euanh
force-pushed
the
docs/update-vapor-example
branch
from
2e1ab06 to
96d74ea
Compare
euanh
added
area/documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The Vapor template repository splits the server into a main entry point file and a separate route installation function. Adopting the same structure makes this example more familiar to users who are used to the official template.
Fixes #61
Modifications
HelloWorldVapor-warnings-as-errorsflag when building end to end examples.Result
The example works in the same way as before but has a more familiar structure for Vapor users.
Test Plan
All tests continue to pass.