This repository was archived by the owner on Jul 11, 2025. It is now read-only.
Fixed the link to otel semantic conventions docs #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slashmo
approved these changes
Oct 30, 2023
There was a problem hiding this comment.
Thanks for bringing this up, @natikgadzhi! What do you think about using a versioned link instead?
Co-authored-by: Moritz Lang <[email protected]>
|
@slashmo, thank you for taking a look, and yep, you're right — versioned is better, gives us more certainty that this one is not going anywhere. |
|
We have new CI now, retriggering |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original link 404s now. They've moved the semantic conversions page out of the specification repo it seems, but there's a nice doc on the website — so I've swapped the link to point to that.