This repository was archived by the owner on Jul 11, 2025. It is now read-only.
Migrate CI to use swiftlang / SwiftNIO common GitHub Actions. #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation:
* Reduce duplication
* Centralise boilerplate changes when new Swift versions are picked up.
* Benefit from centralised work to add new linting / test
infrastructure.
Modifications:
* The new soundness checks from swiftlang/github-workflows required changes. Mostly around licenses.
* After this PR we should come back and enable:
* swift-format formatting (possibly with NIO rules)
* Some unused scripts and the docker files have been removed.
* Adds a script for generating `CONTRIBUTORS.txt` and the file itself
Result:
More test, linting, formatting coverage. More common CI with other Swift
on Server projects.
rnro
added
🆕 semver/minor
|
I forgot to highlight I’d bumped the Swift version in this PR. Fixed now. |
|
Awesome, fixed branch rules |
ktoso
approved these changes
Nov 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Modifications:
CONTRIBUTORS.txtand the file itselfResult:
More test, linting, formatting coverage. More common CI with other Swift on Server projects.