Skip to content
This repository was archived by the owner on Jul 11, 2025. It is now read-only.

Conversation

jmuldoon
Copy link

Built out a suite of Kubernetes SpanAttributes conforming to SemConv of Otel. This adheres to https://opentelemetry.io/docs/specs/semconv/resource/k8s/.

Built out a suite of Kubernetes SpanAttributes conforming to SemConv of Otel. This adheres to https://opentelemetry.io/docs/specs/semconv/resource/k8s/.
@jmuldoon jmuldoon force-pushed the feat/swift-kubernetes-spanattribute-inclusion branch from b74ed80 to 104f202 Compare February 12, 2025 05:28
@ktoso ktoso added the 🆕 semver/minor Adds new public API. label Feb 12, 2025
Missed in initial push
metadata should have been key
@jmuldoon jmuldoon requested a review from ktoso February 12, 2025 06:19
Copy link
Member

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do you want to have a look @slashmo @czechboy0 ?

Copy link
Contributor

@slashmo slashmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to add these attributes here but technically they're resource attributes, meaning they shouldn't need to be attached to individual spans but to the resource exporting them (in OTel terms). So far we only added span convention attributes here.

Apart from that, do we want to stay consistent in the URLs we use to link to the semconv spec? Elsewhere we linked to the repo which has the advantage that we can link to a specific tag, e.g. https://github.com/open-telemetry/opentelemetry-specification/blob/v1.11.0/specification/trace/semantic_conventions/span-general.md#source-code-attributes.

@jmuldoon
Copy link
Author

jmuldoon commented Feb 17, 2025

Apart from that, do we want to stay consistent in the URLs we use to link to the semconv spec? Elsewhere we linked to the repo which has the advantage that we can link to a specific tag, e.g. https://github.com/open-telemetry/opentelemetry-specification/blob/v1.11.0/specification/trace/semantic_conventions/span-general.md#source-code-attributes.

I would like to be consistent and missed that originally as well. Really appreciate the guidance here. I will look to specify the repo link in a forthcoming commit

edit ->

I did a bit of digging, and it looks like the otel upstream have split out semantic-conventions into their own repository here https://github.com/open-telemetry/semantic-conventions/blob/v1.30.0/model/k8s/resources.yaml. I poked around briefly to find the the human readable .md but didn't find it at first quick glance. Might be worth the discussion if there is a further update to cross over with this new repo, and which portion do we position with? the docs or the model itself. I am okay with either, but defer to the maintainer's guidance here before making further changes to the PR.

search journey:

@ktoso
Copy link
Member

ktoso commented Feb 21, 2025

I don't think we mind adding the resource attributes; the links question is real, so... what is the real source of truth nowadays?

And yeah we should maybe do this work over in the swift-otel org repo. maybe just there actually...?

WDYT @jmuldoon @slashmo

@jmuldoon
Copy link
Author

jmuldoon commented May 2, 2025

This PR has been moved to a more appropriate repository where consolidation is planned for conventions in the future across resources. swift-otel/swift-otel-semantic-conventions#3

@jmuldoon jmuldoon closed this May 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🆕 semver/minor Adds new public API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants