Merge pull request #94 from slashmo/feature/write-only-span-links

Remove links getter from Span protocol

Author: ktoso

Sources/Instrumentation/Tracing/NoOpTracing.swift

@@ -39,7 +39,6 @@ public struct NoOpTracingInstrument: TracingInstrument {
         public var operationName: String = ""
         public var status: SpanStatus?
         public let kind: SpanKind = .internal
-        public let links = [SpanLink]()
 
         public var startTimestamp: DispatchTime {
             .now()

Sources/Instrumentation/Tracing/Span.swift

@@ -49,9 +49,6 @@ public protocol Span {
     /// Returns true if this `Span` is recording information like events, attributes, status, etc.
     var isRecording: Bool { get }
 
-    /// The read-only collection of linked `Span`s.
-    var links: [SpanLink] { get }
-
     /// Add a `SpanLink` in place.
     /// - Parameter link: The `SpanLink` to add to this `Span`.
     mutating func addLink(_ link: SpanLink)

Tests/InstrumentationTests/Tracing/TracedLockTests.swift

@@ -92,7 +92,7 @@ private final class TracedLockPrintlnTracer: TracingInstrument {
 
         let baggage: BaggageContext
 
-        private(set) var links = [SpanLink]()
+        private var links = [SpanLink]()
 
         private var events = [SpanEvent]() {
             didSet {

Tests/InstrumentationTests/TracingInstrumentTests.swift

@@ -112,7 +112,7 @@ struct OTSpan: Span {
         }
     }
 
-    private(set) var links = [SpanLink]()
+    private var links = [SpanLink]()
 
     var attributes: SpanAttributes = [:] {
         didSet {