Skip to content

Tracer.withSpan's isolation param should be 'isolated' #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Sources/Tracing/TracerProtocol+Legacy.swift
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,7 @@ extension LegacyTracer {
_ operationName: String,
context: @autoclosure () -> ServiceContext = .current ?? .topLevel,
ofKind kind: SpanKind = .internal,
isolation: (any Actor)? = #isolation,
isolation: isolated (any Actor)? = #isolation,
function: String = #function,
file fileID: String = #fileID,
line: UInt = #line,
Expand Down Expand Up @@ -610,7 +610,7 @@ extension Tracer {
at instant: @autoclosure () -> some TracerInstant = DefaultTracerClock.now,
context: @autoclosure () -> ServiceContext = .current ?? .topLevel,
ofKind kind: SpanKind = .internal,
isolation: (any Actor)? = #isolation,
isolation: isolated (any Actor)? = #isolation,
function: String = #function,
file fileID: String = #fileID,
line: UInt = #line,
Expand Down
4 changes: 2 additions & 2 deletions Sources/Tracing/TracerProtocol.swift
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ extension Tracer {
_ operationName: String,
context: @autoclosure () -> ServiceContext = .current ?? .topLevel,
ofKind kind: SpanKind = .internal,
isolation: (any Actor)? = #isolation,
isolation: isolated (any Actor)? = #isolation,
function: String = #function,
file fileID: String = #fileID,
line: UInt = #line,
Expand Down Expand Up @@ -353,7 +353,7 @@ extension Tracer {
context: @autoclosure () -> ServiceContext = .current ?? .topLevel,
ofKind kind: SpanKind = .internal,
at instant: @autoclosure () -> some TracerInstant = DefaultTracerClock.now,
isolation: (any Actor)? = #isolation,
isolation: isolated (any Actor)? = #isolation,
function: String = #function,
file fileID: String = #fileID,
line: UInt = #line,
Expand Down
Loading