Pushing InMemoryTracer (#180) over the finish line #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
slashmo
approved these changes
Sep 11, 2025
|
|
||
| /// Retrives a specific _active_ span, identified by the specific span, trace, and parent ID's | ||
| /// stored in the `inMemorySpanContext` | ||
| public func activeSpan(identifiedBy context: ServiceContext) -> InMemorySpan? { |
There was a problem hiding this comment.
Should we move this up into to the other Tracer requirements like startSpan instead of this extension?
There was a problem hiding this comment.
Well this is the // MARK: - InMemoryTracer querying so i think this is right here
There was a problem hiding this comment.
Okay, I thought you wanted to separate protocol conformance from additional InMemoryTracer-APIs here. If not I agree it thematically fits better here.
ktoso
force-pushed
the
wip-inmemorytracer
branch
2 times, most recently
from
f1caa85 to
be1b852
Compare
czechboy0
reviewed
Sep 11, 2025
<!-- After your change, what will change. -->
We just ignore writes made after a span was closed; and we ensure a double close won't mutate the timestamp NOR call the the onEnd multiple times. That's the expected baseline behavior.
ktoso
force-pushed
the
wip-inmemorytracer
branch
from
be1b852 to
7dcf986
Compare
ktoso
force-pushed
the
wip-inmemorytracer
branch
from
adc1fd9 to
e5f451c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows up #180 to get it over the finish line.
Main changes:
InMemoryTracerin theInMemoryTracingmodule@slashmo please have a look, you can pick this into your PR if it looks good; I'd love to get this merged and released very soon, since we have PRs piling up in other repos waiting for this :)