Merged
Conversation
fboemer
commented
Jan 16, 2026
fboemer
commented
Jan 16, 2026
...ationProtobuf/generated/apple_swift_homomorphic_encryption_api_shared_v1_api_shared.pb.swift
Show resolved
Hide resolved
31b8519 to
83a9acc
Compare
karulont
reviewed
Jan 19, 2026
...ationProtobuf/generated/apple_swift_homomorphic_encryption_api_shared_v1_api_shared.pb.swift
Show resolved
Hide resolved
karulont
reviewed
Jan 21, 2026
Sources/PrivateInformationRetrieval/IndexPir/IndexPirProtocol.swift
Outdated
Show resolved
Hide resolved
Sources/PrivateInformationRetrieval/IndexPir/IndexPirProtocol.swift
Outdated
Show resolved
Hide resolved
7801982 to
5820132
Compare
karulont
approved these changes
Jan 21, 2026
feimaomiao
pushed a commit
to feimaomiao/swift-homomorphic-encryption
that referenced
this pull request
Jan 22, 2026
* Use encodingEntrySize for IndexPir
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use encodingEntrySize for IndexPir.
We add
encodingEntrySizeto PirParameters which, when enabled, will prepend each IndexPir entry with a VarInt encoding.This is useful to support IndexPir with varying entry sizes (unlike in KeywordPIR, where we just 0-pad to make all the entry sizes match).