SLG-0004: Metadata privacy levels implementation#418
Draft
kukushechkin wants to merge 11 commits intoapple:mainfrom
Draft
SLG-0004: Metadata privacy levels implementation#418kukushechkin wants to merge 11 commits intoapple:mainfrom
kukushechkin wants to merge 11 commits intoapple:mainfrom
Conversation
…hkin/swift-log into metadata-privacy-labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the SLG-0004 proposal introducing an attributed metadata system that allows attaching attributes to metadata values. Privacy level is the first concrete attribute, enabling developers to mark metadata values as
.privateor.publicsoLogHandlerimplementations can redact sensitive values before logging.Motivation:
SwiftLog lacks a mechanism to attach attributes to metadata values as sensitive to allow Log Handlers to control logging behavior.
Modifications:
LoggerandLogHandlerhave new API surface for using Attributed Metadata.Result:
Sensitive metadata values can be marked as
.privateto signal compatible Log Handlers to mask the value when logging.