Skip to content

Strict concurrency for pipeline helpers#503

Merged
glbrntt merged 2 commits intoapple:mainfrom
glbrntt:strict-concurrency-pipeline-helpers
Mar 27, 2025
Merged

Strict concurrency for pipeline helpers#503
glbrntt merged 2 commits intoapple:mainfrom
glbrntt:strict-concurrency-pipeline-helpers

Conversation

@glbrntt
Copy link
Contributor

@glbrntt glbrntt commented Mar 21, 2025

Motivation:

To increase concurrency safety the NIOHTTP2 module should compile without warning under strict concurrency checking.

Modifications:

  • Add a few temporary internal helpers
  • Annotate the pipeline helpers

Result:

Fewer concurrency warnings

Motivation:

To increase concurrency safety the NIOHTTP2 module should compile
without warning under strict concurrency checking.

Modifications:

- Add a few temporary internal helpers
- Annotate the pipeline helpers

Result:

Fewer concurrency warnings
@glbrntt glbrntt added the 🆕 semver/minor Adds new public API. label Mar 21, 2025
@glbrntt
Copy link
Contributor Author

glbrntt commented Mar 21, 2025

API breakage is expected, a func has been marked @preconcurrency:

  💔 API breakage: func ChannelPipeline.configureHTTP2SecureUpgrade(h2PipelineConfigurator:http1PipelineConfigurator:) is now with @preconcurrency

@glbrntt glbrntt requested a review from rnro March 24, 2025 14:54
@glbrntt glbrntt merged commit 0c020df into apple:main Mar 27, 2025
35 of 36 checks passed
@glbrntt glbrntt deleted the strict-concurrency-pipeline-helpers branch March 27, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🆕 semver/minor Adds new public API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants