feat: Enable NIOFoundationCompat to compile using Swift for WebAssembly. Fix NIOCore WASI compilation issue. #3422
Conversation
|
@MaxDesiatov @kateinoigakukun in case you're interested, I'm fixing Swift for WebAssembly compilation for NIOCore and NIOFoundationCompat in this PR. |
| "Bad interface address family" | ||
| case let .illegalMulticastAddress(address): | ||
| "Illegal multicast address \(address)" | ||
| #if !os(WASI) |
There was a problem hiding this comment.
Oddly enough, a previous fix for this compiler error no longer seems to be in main. Not sure why.
There was a problem hiding this comment.
It's pretty likely it got lost in a merge conflict. The perils of not having a running CI job.
There was a problem hiding this comment.
What's the holdup with the Wasm job? I though we had one enabled here already...
There was a problem hiding this comment.
Did this get reverted somehow or how did it not catch the issue? #3332
| "Bad interface address family" | ||
| case let .illegalMulticastAddress(address): | ||
| "Illegal multicast address \(address)" | ||
| #if !os(WASI) |
There was a problem hiding this comment.
It's pretty likely it got lost in a merge conflict. The perils of not having a running CI job.
|
This needs to be updated to the latest |
4 participants
Fix Swift for WebAssembly compilation in NIOCore and NIOFoundationCompat.
Motivation:
NIO is a common dependency, and it is important to enable compiling NIO using Swift for WebAssembly. This PR fixes compilation for NIOCore and NIOFoundationCompat.
Modifications:
Result:
With these changes, the following build commands succeed: ✅
Context:
This PR is part of a larger effort by PassiveLogic to improve Swift for WebAssembly support