Access properties with explicit self in encode(to encoder:)
#699
Conversation
|
@Dragna Thanks for confirming that this resolves the issues with your particular OpenAPI document. Again, apologies for the PR race—I didn't mean for this to supersede your efforts. If you ever want to contribute to the project again, we'd be gladly accept pull requests. |
Thank you for your help, and don't mind the fact that I created a PR, I was lost in the snippet test file and couldn't find the right place where I should have updated the test. Thanks again for taking time on this and helping us 🙏. |
…and encoders (#700) ### Motivation In order to address #695 we made some targeted fixes (#696, #699) to use explicit-self to avoid clashing with schema property names. This addressed a clash with a specific variable with properties of only certain schemas, but there are more places where we might encounter future issues. Specifically, we have other variable names which might cause a clash (e.g. `storage` and `discriminator`), and there are other flavours of initializers, encoders, and decoders that were not updated in the targeted fix. In this PR, we update all access and assignment in the generated code dealing with schemas to use explicit-self. ### Modifications - Use self for member access and assignment in all initializers, decoders, and encoders. - Update the reference tests and snippet tests. ### Result Removed some cases where valid OpenAPI docs would produce non-compiling code. ### Test Plan Snippet and reference tests. The latter is actually compiled during the CI.
3 participants
Motivation
In #696 we avoided clashing with a property called
containerin certain schemas by making use of explicit self ininit(from decoder:). We didn't have access to the OpenAPI document and hadn't caught the case where this was used in a schema that supported additional properties, where we also need to avoid the clash inencode(to encoder:).Modifications
encode(to encoder:).Result
containeras a property name of a model #695Test Plan
More snippet tests and reference tests.