ClientError: don't call our to localizedDescription in description #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We're unlikely to take this PR, as this would expose error types that never opted into logging. However, we will fix the forwarding logic to properly separate description and localizedDescription, tracked by apple/swift-openapi-generator#730. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes apple/swift-openapi-generator#730 . LocalizedDescription doesn't print anything useful for Swift Errors. It just prints
ErrorType code 1regardless what the underlying issue was.That causes real issues when debugging production software.
Modifications
Correct
descriptionto calldescription/String(describing:).Result
Can debug software regardless of the transport.
Test Plan
[Describe the steps you took, or will take, to qualify the change - such as adjusting tests and manual testing.]