Skip to content

Commit d7ba532

Browse files
author
Pouya Yarandi
committed
Fix comments
1 parent eedb785 commit d7ba532

File tree

3 files changed

+21
-16
lines changed

3 files changed

+21
-16
lines changed

Sources/SwiftProtobuf/Message+FieldMask.swift

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -34,18 +34,19 @@ extension Message {
3434
}
3535
}
3636

37-
/// Defines available options for merging two messages.
38-
public struct MergeOption {
37+
extension Google_Protobuf_FieldMask {
3938

40-
public init(replaceRepeatedFields: Bool = false) {
41-
self.replaceRepeatedFields = replaceRepeatedFields
42-
}
39+
/// Defines available options for merging two messages.
40+
public struct MergeOptions {
41+
42+
public init() {}
4343

44-
/// The default merging behavior will append entries from the source
45-
/// repeated field to the destination repeated field. If you only want
46-
/// to keep the entries from the source repeated field, set this flag
47-
/// to true.
48-
public var replaceRepeatedFields = false
44+
/// The default merging behavior will append entries from the source
45+
/// repeated field to the destination repeated field. If you only want
46+
/// to keep the entries from the source repeated field, set this flag
47+
/// to true.
48+
public var replaceRepeatedFields = false
49+
}
4950
}
5051

5152
extension Message {
@@ -58,7 +59,7 @@ extension Message {
5859
public mutating func merge(
5960
from source: Self,
6061
fieldMask: Google_Protobuf_FieldMask,
61-
mergeOption: MergeOption = .init()
62+
mergeOption: Google_Protobuf_FieldMask.MergeOptions = .init()
6263
) throws {
6364
var source = source
6465
var pathToValueMap: [String: Any?] = [:]

Sources/SwiftProtobuf/SetPathDecoder.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ struct SetPathDecoder<T: Message>: Decoder {
5252
private let nextPath: [String]
5353

5454
// Merge options to be concidered while setting value
55-
private let mergeOption: MergeOption
55+
private let mergeOption: Google_Protobuf_FieldMask.MergeOptions
5656

5757
private var replaceRepeatedFields: Bool {
5858
mergeOption.replaceRepeatedFields
@@ -61,7 +61,7 @@ struct SetPathDecoder<T: Message>: Decoder {
6161
init(
6262
path: [String],
6363
value: Any?,
64-
mergeOption: MergeOption
64+
mergeOption: Google_Protobuf_FieldMask.MergeOptions
6565
) {
6666
if let firstComponent = path.first,
6767
let number = T.number(for: firstComponent) {
@@ -385,7 +385,7 @@ extension Message {
385385
mutating func `set`(
386386
path: String,
387387
value: Any?,
388-
mergeOption: MergeOption
388+
mergeOption: Google_Protobuf_FieldMask.MergeOptions
389389
) throws {
390390
let _path = path.components(separatedBy: ".")
391391
var decoder = SetPathDecoder<Self>(

Tests/SwiftProtobufTests/Test_FieldMask.swift

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,9 @@ final class Test_FieldMask: XCTestCase, PBTestHelpers {
151151
XCTAssertEqual(message.repeatedInt32, [1, 2, 3, 4])
152152

153153
// Checks with replacing repeated fields
154-
try message.merge(from: secondMessage, fieldMask: fieldMask, mergeOption: .init(replaceRepeatedFields: true))
154+
var options = Google_Protobuf_FieldMask.MergeOptions()
155+
options.replaceRepeatedFields = true
156+
try message.merge(from: secondMessage, fieldMask: fieldMask, mergeOption: options)
155157
XCTAssertEqual(message.repeatedInt32, [3, 4])
156158
}
157159

@@ -172,7 +174,9 @@ final class Test_FieldMask: XCTestCase, PBTestHelpers {
172174
XCTAssertEqual(message.mapInt32String, [1: "a", 2: "b"])
173175

174176
// Checks with replacing repeated fields
175-
try message.merge(from: secondMessage, fieldMask: fieldMask, mergeOption: .init(replaceRepeatedFields: true))
177+
var options = Google_Protobuf_FieldMask.MergeOptions()
178+
options.replaceRepeatedFields = true
179+
try message.merge(from: secondMessage, fieldMask: fieldMask, mergeOption: options)
176180
XCTAssertEqual(message.mapInt32String, [2: "b"])
177181
}
178182

0 commit comments

Comments
 (0)