Add a initializer to Google_Protobuf_Timestamp with rounding control#1748
Merged
thomasvl merged 4 commits intoapple:mainfrom Jan 28, 2025
Merged
Add a initializer to Google_Protobuf_Timestamp with rounding control#1748thomasvl merged 4 commits intoapple:mainfrom
thomasvl merged 4 commits intoapple:mainfrom
Conversation
Provide a new initializer with explicit rounding controls and map the other initializer though the single code paths. Deprecate the old apis to direct folks to the new one to acknowledge the rounding that is happening on their values.
thomasvl
commented
Jan 23, 2025
allevato
approved these changes
Jan 23, 2025
Sources/SwiftProtobuf/Google_Protobuf_Timestamp+Extensions.swift
Outdated
Show resolved
Hide resolved
Rephrase comments Co-authored-by: Tony Allevato <tony.allevato@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide a new initializer with explicit rounding controls and map the other initializer though the single code paths.
Deprecate the old apis to direct folks to the new one to acknowledge the rounding that is happening on their values.