Skip to content

Conversation

@Gogopex
Copy link

@Gogopex Gogopex commented Jan 21, 2026

Summary

  • migrate SwiftProtobufPlugin from deprecated Path APIs to URL-based APIs
  • avoid storing non-Sendable Target in PluginError by capturing target type description
  • update documentation comments for URL parameters

Testing

  • swift build
  • ran swift test locally, too

@thomasvl
Copy link
Collaborator

Seems like this might overlap #1912? We're waiting for oss-fuzz to land a PR that updates what version of Swift is used there so we can drop 5.10 and thus not having to make the plugin updates conditional on the verison.

@Gogopex
Copy link
Author

Gogopex commented Jan 22, 2026

crap, thank @thomasvl, I did not see #1912, my bad for not checking beforehand. I was just getting annoyed at the warnings while rebuilding my project every 30mn.

Feel free to close this (or tell me to) if this ends up not needed, else we can park it there just in case.

Ty!

@thomasvl
Copy link
Collaborator

crap, thank @thomasvl, I did not see #1912, my bad for not checking beforehand. I was just getting annoyed at the warnings while rebuilding my project every 30mn.

Feel free to close this (or tell me to) if this ends up not needed, else we can park it there just in case.

Ty!

No worries, just wanted to be sure it was for the same concerns as the other.

Sadly, we've been blocked on getting oss-fuzz updated for a while now (early December?), we'd rather not lose that safety net so we've had to keep 5.10 support around as a result. And to "fix" the warnings you mention would mean some conditional code to deal with the different versions and we just keep hoping that we'll be able to drop 5.10 soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants