MachPort inlinability fixes #289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test macOS platform |
When compiled with library resilience, `consuming` functions which `discard self` cannot also be `@inlinable`.
glessard
force-pushed
the
issue288-resilient-machport
branch
from
5a03cc6 to
b0e5ec8
Compare
Contributor
Author
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiled with library resilience,
consumingfunctions whichdiscard selfcannot also be@inlinable. While this does not cause issues in the package (it is not compiled with resilience on,) this is a back-port of an internal bug fix. A diagnostic for this error is introduced in Swift 6.3.Addresses #288