Add functions that take struct vxi11_client_t as a parameter#3
Open
levens wants to merge 6 commits intoapplied-optics:masterfrom
Open
Add functions that take struct vxi11_client_t as a parameter#3levens wants to merge 6 commits intoapplied-optics:masterfrom
levens wants to merge 6 commits intoapplied-optics:masterfrom
Conversation
VXI11_CLIENTS is no longer a global variable but is instead passed to the open/close functions. In a multithreaded application the global variable causes problems. Instead it is up to the calling code to protect this variable.
Conflicts: library/vxi11_user.c library/vxi11_user.h
vxi11_open_device() and vxi11_close_device() no longer have an argument for the clients, these functions again use a global variable. Two new functions are added, vxi11_open_device_clients() and vxi11_close_device_clients() to offer the option to pass an external clients list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds functions that, instead of using the global
VXI11_CLIENTS, accept the struct as a parameter. This came from the need for the use of the library in a multi-threaded application where each thread manages its own data.