Skip to content

Conversation

@zeluisping
Copy link

@zeluisping zeluisping commented Aug 22, 2025

It's not working with the backend submission. I did not get to look into it. I believe it might be due to the lack of receipts, but that is just a guess.

This pull request introduces a new set of utilities for smart account deployment and error handling, refactors entry point definitions, and adds new provider types for custom blockchain operations. The main changes are grouped into three themes: Smart Account Deployment, Error Handling, and Provider/Entry Point Improvements.

Smart Account Deployment Utilities

  • Added ensureSmartAccountIsDeployed, isSmartAccountDeployed, and waitForSmartAccountDeployment functions to facilitate checking, deploying, and waiting for smart account deployment on-chain. These utilities are documented and exported for use throughout the codebase. [1] [2] [3] [4] [5]

Error Handling Improvements

  • Introduced a new base error class GianoError with support for error chaining and proper prototype setup, along with specialized error types for smart account deployment and timeouts. These are now exported for both Node and web environments. [1] [2] [3] [4]

Provider and Entry Point Refactoring

  • Refactored Giano entry point definitions to use explicit types and constants for ABI, address, and version, improving clarity and maintainability. [1] [2] [3] [4] [5]
  • Expanded provider custom methods and introduced generic ProviderRequestMethod typing, supporting new operations such as signed calls and user operation management. [1] [2] [3] [4]

These updates provide a more robust foundation for smart account abstraction, error management, and custom provider interactions.

@zeluisping zeluisping requested a review from jophj August 22, 2025 17:40
@zeluisping zeluisping self-assigned this Aug 22, 2025
@zeluisping zeluisping added the enhancement New feature or request label Aug 22, 2025
@coderabbitai
Copy link

coderabbitai bot commented Aug 22, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/sdr-chain-support

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@zeluisping zeluisping force-pushed the feat/sdr-chain-support branch from 1db38ce to 7672ee7 Compare November 3, 2025 10:42
@zeluisping
Copy link
Author

Fixed conflicts with target branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants