feat: events service private event support #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seromenho
reviewed
Nov 12, 2025
| 'event UserOperationEvent(bytes32 indexed userOpHash, address indexed sender, address indexed paymaster, uint256 nonce, bool success, uint256 actualGasCost, uint256 actualGasUsed)', | ||
| 'event AccountDeployed(bytes32 indexed userOpHash, address indexed sender, address factory, address paymaster)', | ||
| // PrivateEvent: UserOperationEvent, AccountDeployed | ||
| 'event PrivateEvent(address[] allowedViewers, bytes32 indexed eventType, bytes payload)', |
There was a problem hiding this comment.
pollEvents uses the regular publicClient, which doesn't have Silent Data auth headers, and private events doesn't work
|
|
||
| try { | ||
| // type cast to unwrap EventLog<UserOperationEventAbi | AccountDeployedAbi> | ||
| return unwrapPrivateEvent(abi, ev) as ( |
There was a problem hiding this comment.
Same as the other comment. We should use the existing parseEvent.
| import { EntryPoint__factory } from "@skandha/types/lib/contracts/EPv7/factories/core"; | ||
| import { GetContractReturnType, Hex, PublicClient, Log, parseAbi } from "viem"; | ||
|
|
||
| type UserOperationEventAbi = { |
There was a problem hiding this comment.
I wouldn't get rid of these events ABIs. When parsing a private event, the inner event follows this ABI.
| return null | ||
| } | ||
|
|
||
| const wrappedEventHashToAbi = { |
There was a problem hiding this comment.
This can live outside of the function scope.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR integrates private event support into the EventsService, enabling it to watch and process private EntryPoint events.
Key Changes:
utils/abi-eventsinstead of local duplicateswatchContractEventsubscription forPrivateEventemissions, filtering by event type forUserOperationEventandAccountDeployedhandlePrivateEventUnwrap()method that decodes and reconstructs private events into standard event logshandleEvent()to transparently unwrap private events before processing, maintaining the same flow for both public and private eventsImplementation Details:
eventTypehashes to their corresponding ABIs (UserOperationEventAbi,AccountDeployedAbi) for proper decodingEventLog<ABI>helper typeTypes of changes
What types of changes does your code introduce?
Put an
xin the boxes that applyUserOperationEvent, andAccountDeployedFurther comments (optional)
PrivateEventwith specificeventTypefilters to only process relevant events (UserOperationEventandAccountDeployed)