Introduce Jimfs to host files during testing#37
Open
davidburstromspotify wants to merge 5 commits intoappmattus:mainfrom
Open
Introduce Jimfs to host files during testing#37davidburstromspotify wants to merge 5 commits intoappmattus:mainfrom
davidburstromspotify wants to merge 5 commits intoappmattus:mainfrom
Conversation
Introducing Jimfs to the RuleProcessorTest, the RuleProcessor runs successfully without referencing the default filesystem. The only required fix was to ensure the SinglePathFilter resolves files based on the target Path underlying filesystem instead of the default one.
Especially when using a virtual file system like Jimfs, the '/' directory is a feasible root for analysis, but it has no filename component.
If building the project in e.g. x:/ Gradle cannot work out the intended root project name based on the directory.
Contributor
Author
|
@mattmook Hi Matt! Let me know if you'd like me to address anything. |
Contributor
Author
|
@mattmook The Windows issue seems to happen even on current main:HEAD, independently of my PR. |
It leads to intermittent build failures, both locally and in CI.
Contributor
Author
|
After some debugging it looks as it's the JaCoCo agent that gets applied through |
Contributor
Author
|
Hi @mattmook! Do you think this could be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This proves that the processor is independent of the default filesystem.