[APDM-1956] Fix DM work on Unity v6.4-beta#138
Merged
DmitriiFeshchenko merged 2 commits intorelease/4.1.0from Feb 27, 2026
Merged
[APDM-1956] Fix DM work on Unity v6.4-beta#138DmitriiFeshchenko merged 2 commits intorelease/4.1.0from
DmitriiFeshchenko merged 2 commits intorelease/4.1.0from
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates two custom UIElements classes to support Unity 6.x's new UIElement registration system while maintaining backward compatibility with older Unity versions. Unity 6.x deprecated the old UxmlFactory pattern in favor of the [UxmlElement] attribute on partial classes.
Changes:
- Added conditional compilation to use
[UxmlElement]attribute for Unity 6.x and newer - Changed classes from regular to partial classes to support the new attribute-based registration
- Wrapped legacy
UxmlFactorydeclarations in conditional compilation for pre-Unity 6.x versions
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Editor/DependencyManager/UIElements/Widgets/Sdk/VersionDropdown/SdkVersionDropdown.cs | Updated UIElement registration to support Unity 6.x using [UxmlElement] attribute and partial class, with conditional compilation for backward compatibility |
| Editor/DependencyManager/UIElements/Widgets/Sdk/Cards/Shell/SdkCardShell.cs | Updated UIElement registration to support Unity 6.x using [UxmlElement] attribute and partial class, with conditional compilation for backward compatibility |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
johnlitvinov
approved these changes
Feb 26, 2026
Khrolovich
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.