[APDM-2058] Fix OnAdRevenueReceived callback discrepancies#140
Merged
DmitriiFeshchenko merged 3 commits intorelease/4.1.0from Feb 27, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request fixes ad revenue callback discrepancies by modifying the Android implementation to deliver ad revenue data on a background thread instead of dispatching to Unity's main thread. This change reduces data loss and timing discrepancies when forwarding ad revenue information to Mobile Measurement Partners (MMPs), aligning the Android behavior with the existing iOS implementation.
Changes:
- Removed
UnityMainThreadDispatcher.Postwrapper fromOnAdRevenueReceivedcallbacks in Android implementation - Added comprehensive documentation explaining that the callback now executes on a background thread on Android
- Added guidance for developers to manually dispatch Unity API interactions to the main thread when needed
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Runtime/Platforms/Android/Callbacks/AppodealAdRevenueCallback.cs | Removed thread dispatching to invoke callbacks directly on background thread, preventing delays and potential data loss |
| Runtime/Common/Events/Public/Scripts/AppodealCallbacks.cs | Added XML documentation remarks explaining the background thread behavior and linking to documentation |
| Runtime/Common/Events/Public/Interfaces/IAdRevenueListener.cs | Added XML documentation remarks to interface method explaining threading implications for implementers |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Khrolovich
approved these changes
Feb 27, 2026
…emove-context-sync
…emove-context-sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.