Skip to content

[APDM-2058] Fix OnAdRevenueReceived callback discrepancies#140

Merged
DmitriiFeshchenko merged 3 commits intorelease/4.1.0from
fix/APDM-2058-ad-revenue-callback-remove-context-sync
Feb 27, 2026
Merged

[APDM-2058] Fix OnAdRevenueReceived callback discrepancies#140
DmitriiFeshchenko merged 3 commits intorelease/4.1.0from
fix/APDM-2058-ad-revenue-callback-remove-context-sync

Conversation

@DmitriiFeshchenko
Copy link
Collaborator

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request fixes ad revenue callback discrepancies by modifying the Android implementation to deliver ad revenue data on a background thread instead of dispatching to Unity's main thread. This change reduces data loss and timing discrepancies when forwarding ad revenue information to Mobile Measurement Partners (MMPs), aligning the Android behavior with the existing iOS implementation.

Changes:

  • Removed UnityMainThreadDispatcher.Post wrapper from OnAdRevenueReceived callbacks in Android implementation
  • Added comprehensive documentation explaining that the callback now executes on a background thread on Android
  • Added guidance for developers to manually dispatch Unity API interactions to the main thread when needed

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
Runtime/Platforms/Android/Callbacks/AppodealAdRevenueCallback.cs Removed thread dispatching to invoke callbacks directly on background thread, preventing delays and potential data loss
Runtime/Common/Events/Public/Scripts/AppodealCallbacks.cs Added XML documentation remarks explaining the background thread behavior and linking to documentation
Runtime/Common/Events/Public/Interfaces/IAdRevenueListener.cs Added XML documentation remarks to interface method explaining threading implications for implementers

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@DmitriiFeshchenko DmitriiFeshchenko merged commit 69012be into release/4.1.0 Feb 27, 2026
2 checks passed
@DmitriiFeshchenko DmitriiFeshchenko deleted the fix/APDM-2058-ad-revenue-callback-remove-context-sync branch February 27, 2026 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants