Switch pack version based on builder #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmorley
reviewed
Jun 16, 2025
| cmd := exec.Command("pack", "config", "registry-mirrors", "add", "index.docker.io", "--mirror", DockerHubMirror) | ||
| builder := b.BuildpackBuilders()[0] | ||
| packBinary := "pack" | ||
| if builder == "heroku/buildpacks:20" { |
There was a problem hiding this comment.
@ipmb Hi! Do you have metrics as to what proportion of your users are using the legacy heroku/buildpacks:* images (vs the heroku/builder:* images)? We had been planning on making the heroku/buildpacks repo private at some point to prevent people unknowingly using an insecure image (it hasn't had security updates since May 2024), but wouldn't want that to cause too much disruption to you/your users.
Member
Author
There was a problem hiding this comment.
Hey @edmorley! This is the blocker for moving our last user over to CNB heroku/buildpacks-deb-packages#110
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
heroku/buildpacks:20will not build on versions newer than0.31.0heroku/builder:24will not build on0.31.0This installs the latest version and
0.31.0and switches the version used based on the builder specified.