Feature/merge remove binary target by ivolz · Pull Request #23 · approov/approov-service-alamofire

ivolz · 2026-03-18T15:28:58Z

No description provided.

- Ported USAGE.md and REFERENCE.md from URLSession to document Alamofire specifics - Created CHANGELOG.md and seeded with upcoming 3.5.5 release notes - Completely removed the deprecated 'setProceedOnNetworkFailure' API and its logic - Introduced 'ApproovServiceMutator' to allow customizing ApproovService behavior natively - Wired precheck, fetch requests, and interceptors to default mutator fallbacks - Deprecated and removed 'ApproovInterceptorExtensions' - Updated 'ApproovDefaultMessageSigning' to implement 'ApproovServiceMutator' - 'ApproovDefaultMessageSigning' now gracefully skips install message signing instead of throwing if the key is missing

- Replicating React Native functionality, ApproovService can now be configured to put token fetch failure reasons into the token header if no token is fetched - Refactored updateRequestWithApproov execution logic to solve a bug where the ApproovServiceMutator's decision to proceed was overwritten by a legacy hardcoded switch block on the token fetch status

- Introduced enum (.off, .error, .warning, .info, .debug). - Added static function in to configure the global log level. Default is . - Updated all internal statements in and to be conditionally executed based on the current . - Updated with version notes. - Documented logging usage and configuration inside .

ApproovDefaultMessageSigning accesses ApproovService.loggingLevel from a separate file, which requires internal (not private) visibility.

…ersion

…ent API

…ring content but type

… SDK

Copilot

Pull request overview

This PR refactors the Approov Alamofire service layer to remove the embedded/binary Approov SDK target, introduce a more general mutator-based customization API, and expand end-user documentation. It also updates packaging metadata (SPM/CocoaPods) to reflect the new integration approach.

Changes:

Introduces ApproovServiceMutator (and migrates message signing/customization hooks onto it), plus new ApproovLogLevel/logging gating and setUseApproovStatusIfNoToken.
Updates Swift Package Manager/CocoaPods configuration (adds approov-ios-sdk as a dependency, removes the prior binary target, renames package/product/module identifiers).
Adds/updates documentation files (USAGE.md, REFERENCE.md, CHANGELOG.md, README updates).

Reviewed changes

Copilot reviewed 11 out of 13 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
build.log	Adds an Xcode build transcript (currently includes local paths and build failures).
USAGE.md	New usage guide focusing on mutators, message signing, and logging/status options.
Sources/ApproovSession/ApproovSession.swift	Updates interceptor call site to the new `updateRequestWithApproov` signature.
Sources/ApproovSession/ApproovServiceMutator.swift	Adds the new mutator protocol and default behaviors.
Sources/ApproovSession/ApproovService.swift	Implements mutator wiring, logging levels, status-in-token option, and removes proceed-on-network-failure flag.
Sources/ApproovSession/ApproovInterceptorExtensions.swift	Deprecates the old interceptor extensions protocol and bridges it to the mutator API.
Sources/ApproovSession/ApproovDefaultMessageSigning.swift	Migrates message signing to `ApproovServiceMutator` and uses configured token header name.
REFERENCE.md	New API reference for `ApproovService` public methods.
README.md	Adds SPM import guidance and clarifies primary session type.
Package.swift	Renames package/products, removes binary target usage, and adds `approov-ios-sdk` dependency.
Package.resolved	Updates pinned versions (currently missing the new `approov-ios-sdk` pin).
CHANGELOG.md	New changelog describing added/changed/deprecated/removed items for 3.5.5.
ApproovSession.podspec	Updates version and sets module name to `ApproovAFSession`; adds extra dependency.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

REFERENCE.md

ApproovSession.podspec

Sources/ApproovSession/ApproovService.swift

Sources/ApproovSession/ApproovServiceMutator.swift

REFERENCE.md

USAGE.md

Package.swift

REFERENCE.md

…all os_log behind loggingLevel - Restore unconditional throws for .noNetwork/.poorNetwork/.mitmDetected in handleInterceptorFetchTokenResult, handleInterceptorHeaderSubstitutionResult, and handleInterceptorQueryParamSubstitutionResult. This fixes a regression introduced when setProceedOnNetworkFailure was removed, which inadvertently allowed requests to proceed without a token on network failure. - Gate all os_log calls in ApproovTrustManager behind ApproovService.loggingLevel so that setLoggingLevel controls all package logging consistently. - Fix logging level guard mismatch in ApproovDefaultMessageSigning (.info -> .error) to match the actual os_log type and gated remaining debug statements. - Make loggingLevel thread-safe with dedicated loggingQueue to prevent data races.

Copilot

Pull request overview

This PR refactors the Alamofire service layer to remove the embedded binary SDK target and introduce a more flexible customization surface via ApproovServiceMutator, alongside new logging controls and expanded documentation.

Changes:

Rename the SwiftPM package/module/product to ApproovAFSession and switch to depending on approov-ios-sdk as a normal SwiftPM dependency (removing the binary target).
Add ApproovServiceMutator and update ApproovService interception/signing hooks to flow through the mutator; deprecate ApproovInterceptorExtensions compatibility APIs.
Introduce ApproovLogLevel and gate os_log calls across the service (including trust manager and message signing), plus add USAGE.md/REFERENCE.md/CHANGELOG.md.

Reviewed changes

Copilot reviewed 12 out of 14 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
build.log	Adds a local build log artifact (should not be committed).
USAGE.md	New usage guide documenting mutators, signing, binding, and logging.
Sources/ApproovSession/ApproovTrustManager.swift	Gates pinning logs behind `ApproovService.loggingLevel`.
Sources/ApproovSession/ApproovSession.swift	Updates interceptor call to new `updateRequestWithApproov` signature.
Sources/ApproovSession/ApproovServiceMutator.swift	Adds mutator protocol + default implementation.
Sources/ApproovSession/ApproovService.swift	Adds logging level, mutator plumbing, status-as-token option, removes proceed-on-network-fail, updates request processing.
Sources/ApproovSession/ApproovInterceptorExtensions.swift	Deprecates old extension protocol and bridges to mutator hook.
Sources/ApproovSession/ApproovDefaultMessageSigning.swift	Migrates signing to `ApproovServiceMutator`, gates logs, uses configured token header.
REFERENCE.md	New API reference for `ApproovService`.
README.md	Updates import/module guidance for SwiftPM.
Package.swift	Renames package/products/target, adds `approov-ios-sdk` dependency, removes binary target.
Package.resolved	Updates dependency lock versions.
CHANGELOG.md	New changelog documenting 3.5.5 changes.
ApproovSession.podspec	Bumps version and sets CocoaPods module name to `ApproovAFSession`; adds dependency.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sources/ApproovSession/ApproovService.swift

Sources/ApproovSession/ApproovDefaultMessageSigning.swift

Sources/ApproovSession/ApproovSession.swift

Sources/ApproovSession/ApproovService.swift

…ov/approov-service-alamofire into feature/merge-remove-binary-target

Copilot

Pull request overview

Copilot reviewed 12 out of 14 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sources/ApproovSession/ApproovService.swift

Sources/ApproovSession/ApproovServiceMutator.swift

Package.swift

Sources/ApproovSession/ApproovService.swift

…MessageSigning

Copilot

Pull request overview

Copilot reviewed 12 out of 14 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Package.swift

…ubstitutions

Copilot

Pull request overview

Copilot reviewed 12 out of 14 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

CHANGELOG.md

Package.swift

ApproovSession.podspec

Copilot

Pull request overview

Copilot reviewed 12 out of 14 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sources/ApproovSession/ApproovService.swift

Copilot

Pull request overview

Copilot reviewed 12 out of 14 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sources/ApproovSession/ApproovTrustManager.swift

Copilot

Pull request overview

Copilot reviewed 12 out of 14 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

USAGE.md

ivo liondov added 16 commits March 6, 2026 10:54

docs: Document setUseApproovStatusIfNoToken configuration

b0ba848

Add loLevel description

b9552a1

fix: change loggingLevel from private to internal access

4e92a88

ApproovDefaultMessageSigning accesses ApproovService.loggingLevel from a separate file, which requires internal (not private) visibility.

Add swift pm changes to Approov binary dependency; increase package v…

4382675

…ersion

Remove test file

374e4fd

Module name for cocoapods spec file now matches swift pm

c399434

Update documentation to reflect package name change

5b16bc5

Add a getter for current token header

5ae8fde

fix: restore mutator compatibility and align Alamofire docs with curr…

5cf6637

…ent API

fix: Approov exception for SDK already initialized is not based on st…

6824a9d

…ring content but type

USAGE.md now reflects multiple service layers using the same platform…

48ae004

… SDK

Add sfv library dependency to support message signing in podspec

ed080ce

Update docs

55aa5b3

ivolz requested review from adriantuk and Copilot March 18, 2026 15:28

Copilot started reviewing on behalf of ivolz March 18, 2026 15:29 View session

Copilot AI reviewed Mar 18, 2026

View reviewed changes

ivo liondov added 2 commits March 20, 2026 12:18

Update version info

0dc3e9f

ivolz requested a review from Copilot March 20, 2026 12:39

Copilot started reviewing on behalf of ivolz March 20, 2026 12:40 View session

Copilot AI reviewed Mar 20, 2026

View reviewed changes

ivo liondov added 2 commits March 20, 2026 13:09

Update version info

bfedf72

Merge branch 'feature/merge-remove-binary-target' of github.com:appro…

39283ae

…ov/approov-service-alamofire into feature/merge-remove-binary-target

ivolz requested a review from Copilot March 20, 2026 13:13

Copilot started reviewing on behalf of ivolz March 20, 2026 13:14 View session

Copilot AI reviewed Mar 20, 2026

View reviewed changes

fix: implement backward-compatible processedRequest in ApproovDefault…

3bc9b5a

…MessageSigning

ivolz requested a review from Copilot March 20, 2026 13:38

Copilot started reviewing on behalf of ivolz March 20, 2026 13:38 View session

Copilot AI reviewed Mar 20, 2026

View reviewed changes

Package.swift Show resolved Hide resolved

fix: remove contradiction allowing unprotectedURL to undergo header s…

f63bbe5

…ubstitutions

ivolz requested a review from Copilot March 20, 2026 14:31

Copilot started reviewing on behalf of ivolz March 20, 2026 14:32 View session

Copilot AI reviewed Mar 20, 2026

View reviewed changes

CHANGELOG.md Show resolved Hide resolved

Package.swift Show resolved Hide resolved

ApproovSession.podspec Show resolved Hide resolved

ivolz requested a review from Copilot March 20, 2026 14:39

Copilot started reviewing on behalf of ivolz March 20, 2026 14:39 View session

build: add Alamofire dependency to podspec to match SwiftPM

5e68c9a

Copilot AI reviewed Mar 20, 2026

View reviewed changes

Fix link to status token fetch

b742380

ivolz requested a review from Copilot March 22, 2026 12:26

Copilot started reviewing on behalf of ivolz March 22, 2026 12:27 View session

Copilot AI reviewed Mar 22, 2026

View reviewed changes

Sources/ApproovSession/ApproovTrustManager.swift Outdated Show resolved Hide resolved

Minor changes to logging events

805d5b5

ivolz requested a review from Copilot March 23, 2026 08:52

Copilot started reviewing on behalf of ivolz March 23, 2026 08:53 View session

Copilot AI reviewed Mar 23, 2026

View reviewed changes

USAGE.md Show resolved Hide resolved

ivo liondov added 4 commits March 23, 2026 13:14

Add Alamofire specific configuration options

18b1b87

Update reference file

b7e9351

Remove log file

0287593

Add missing error types

0a2c170

Conversation

ivolz commented Mar 18, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants