Conversation
Imtiaz246
reviewed
Jan 28, 2025
| } | ||
| podresources := make([]corev1alpha1.ComputeResource, 0, len(podList.Items)) | ||
| for _, pod := range podList.Items { | ||
| pr := corev1alpha1.ComputeResource{ |
Member
There was a problem hiding this comment.
We will need pod uid to track auto scaling pods.
| for _, pvc := range pvcList.Items { | ||
| if pvc.Status.Phase == core.ClaimBound { | ||
| pvcresources = append(pvcresources, corev1alpha1.StorageResource{ | ||
| Name: pvc.Name, |
Member
There was a problem hiding this comment.
Also need uid to track pvc with same name.
Member
There was a problem hiding this comment.
We never do pvc deletion from operators. If someone delete it manually, thats seperate thing. So, may be only pod uid is enough
Signed-off-by: Tamal Saha <tamal@appscode.com>
Signed-off-by: Arnob kumar saha <arnob@appscode.com>
![kodiak-appscode[bot]](https://avatars.githubusercontent.com/in/92481?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.