Match on the entire backtrace path line #661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unflxw
added
the
bug
tombruijn
requested changes
Sep 30, 2025
Ah, needs rebasing on top of #660, which I will merge now. It worked locally because I was working on top of it. |
unflxw
force-pushed
the
fix-match-backtrace-path-spaces
branch
3 times, most recently
from
9541de3 to
161ad51
Compare
lipskis
approved these changes
Sep 30, 2025
On the `SAFARI_FF_PATH` regular expressions, match the whole line from beginning to end, repeating the matching at the beginning of the line that is done by the `IS_SAFARI_FF` regular expression. Split the `CHROME_PATH` regular expression into two variants of it, with and without a function name. When the function name is present, the path appears in parenthesis, making it easier to delimit it. Attempt to match the version where the path is in parenthesis first, then the version where the path stands alone. On both variants, like with `SAFARI_FF_PATH`, match the whole line from beginning to end. This fixes a bug where the regular expressions would only match the last space-separated segment of a path containing spaces.
unflxw
force-pushed
the
fix-match-backtrace-path-spaces
branch
from
161ad51 to
51783cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the
SAFARI_FF_PATHregular expressions, match the whole line from beginning to end, repeating the matching at the beginning of the line that is done by theIS_SAFARI_FFregular expression.Split the
CHROME_PATHregular expression into two variants of it, with and without a function name. When the function name is present, the path appears in parenthesis, making it easier to delimit it. Attempt to match the version where the path is in parenthesis first, then the version where the path stands alone.This fixes a bug where the regular expressions would only match the last space-separated segment of a path containing spaces.