09/07 - Daily promotion #41100

shadabbuchh · 2025-07-09T07:45:57Z

Description

Tip

Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).

Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags=""

🔍 Cypress test results

Caution

If you modify the content in this section, you are likely to disrupt the CI result for your PR.

Communication

Should the DevRel and Marketing teams inform users about this change?

Yes
No

## Description Add unit tests for multiOrgDomains ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results  > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/16044975912> > Commit: 9f865d9 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=16044975912&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Thu, 03 Jul 2025 08:48:25 UTC  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No  ## Summary by CodeRabbit * **Tests** * Added comprehensive unit tests for multi-organization domain utilities, including domain validation, recent domain tracking, retrieval, and clearing of stored domains. * Ensured robust handling of edge cases, malformed data, and cookie management behaviors.

#41078) Fixes: #41069 - Introduced a new command to enable form login via the CLI. - Added utility functions to parse and retrieve Redis URL from environment variables and configuration files, improving error handling and robustness. This update enhances the application's command-line interface and improves the management of Redis configurations. ## Description > [!TIP] > _Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team)._ > > _Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR._ Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="" ### 🔍 Cypress test results  > [!WARNING] > Tests have not run on the HEAD b3f0ca4 yet > <hr>Mon, 07 Jul 2025 11:35:33 UTC  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No  ## Summary by CodeRabbit ## Summary by CodeRabbit * **New Features** * Added a new CLI command to enable form login for an organization. * **Improvements** * Enhanced environment and Redis URL handling with validation and error logging for improved reliability.  First: ![image](https://github.com/user-attachments/assets/6b4ad8b0-5aa0-4ff9-816a-fd6830a6c93b) Second: ![image](https://github.com/user-attachments/assets/0f6b49ab-8630-4f8e-bb48-d01e01ca8f16) Third: ![image](https://github.com/user-attachments/assets/9d46c00e-52ad-482e-9aba-a49870293a4d) Fourth: ![image](https://github.com/user-attachments/assets/7b3097bb-a16f-4cf5-a223-4e25a41758bc)

## Description Removed redundant klona used by the reactive action flow. > > _Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR._ Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results  > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/16114695042> > Commit: ac67b38 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=16114695042&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Mon, 07 Jul 2025 11:54:41 UTC  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No  ## Summary by CodeRabbit * **Refactor** * Simplified evaluation logic by removing redundant parameters related to previous evaluation tree snapshots across evaluation and trigger handling processes. * Streamlined method signatures and internal calls for improved maintainability. * **Tests** * Updated test cases to align with refactored function signatures, removing unnecessary arguments without affecting test coverage or outcomes.

…41091) Added a check to ensure that the organization data retrieved during the form login enablement process is valid. This prevents potential errors when the organization with the specified slug is not found in the database. ## Description > [!TIP] > _Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team)._ > > _Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR._ Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="" ### 🔍 Cypress test results  > [!CAUTION] > If you modify the content in this section, you are likely to disrupt the CI result for your PR.  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No  ## Summary by CodeRabbit * **Refactor** * Improved code readability and simplified control flow in Redis URL utility functions. No changes to functionality or user-facing behavior.

…ors in the Reactive flow (#41090) ## Description Adding an additional check to show correct cyclic dependency errors in the Reactive flow Fixes [#41070](#41070) ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results  > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/16123657082> > Commit: 278e7c4 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=16123657082&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Mon, 07 Jul 2025 18:39:20 UTC  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No  ## Summary by CodeRabbit * **Bug Fixes** * Improved error detection for reactive dependency misuse, ensuring errors are only raised when trigger and data paths originate from the same entity.

coderabbitai · 2025-07-09T07:46:04Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (2)

pg
release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

RakshaKShetty

Approved

jacquesikot and others added 5 commits July 7, 2025 02:50

shadabbuchh requested a review from RakshaKShetty July 9, 2025 07:45

shadabbuchh requested a review from ApekshaBhosale as a code owner July 9, 2025 07:45

RakshaKShetty approved these changes Jul 9, 2025

View reviewed changes

btsgh merged commit 7ffb554 into master Jul 9, 2025
455 of 462 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

09/07 - Daily promotion #41100

09/07 - Daily promotion #41100

Uh oh!

shadabbuchh commented Jul 9, 2025

Uh oh!

coderabbitai bot commented Jul 9, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

RakshaKShetty left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

09/07 - Daily promotion #41100

09/07 - Daily promotion #41100

Uh oh!

Conversation

shadabbuchh commented Jul 9, 2025

Description

Automation

🔍 Cypress test results

Communication

Uh oh!

coderabbitai bot commented Jul 9, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

RakshaKShetty left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants