Skip to content

Conversation

@btsgh
Copy link
Collaborator

@btsgh btsgh commented Aug 21, 2025

Description

Tip

Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).

Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags=""

🔍 Cypress test results

Caution

If you modify the content in this section, you are likely to disrupt the CI result for your PR.

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

ankitakinger and others added 2 commits August 20, 2025 11:39
…xed height container (#41178)

## Description

Removing a line of code to fix extra space issue on Page with Fixed
height container once switched from a Page with Auto height container.
Also, manually tested out all issues from
[#19082](#19082) to confirm
nothing else breaks from the time these lines were added in the code.

Fixes [#41180](#41180)

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/17043252133>
> Commit: c8bde12
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=17043252133&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Mon, 18 Aug 2025 17:04:42 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Bug Fixes**
* Improved main container auto-height calculation to eliminate
unintended extra spacing, resulting in more accurate, content-driven
sizing.

* **Chores**
* Added diagnostic logging around main container size computation in
view mode to aid troubleshooting (no functional impact).
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
…lan (#41168)

## Summary
Updates the tooltip text for disabled environment switching to reference
"enterprise plan" instead of "business plan" to align with current
product terminology.

## Changes
- Added new `ENTERPRISE_EDITION_TEXT` constant in
`ce/constants/messages.ts`
- Updated `SwitchEnvironment` component to use the new enterprise text
constant
- Maintains backward compatibility by keeping the original
`BUSINESS_EDITION_TEXT` constant

## Files Changed
- `app/client/src/ce/constants/messages.ts` - Added new enterprise text
constant
- `app/client/src/ce/components/SwitchEnvironment/index.tsx` - Updated
tooltip to use enterprise terminology

## Testing
- [ ] Verify tooltip displays "enterprise plan" text when environment
switching is disabled
- [ ] Confirm tooltip link functionality remains unchanged

## Impact
This is a minor UI text update with no functional changes. Users will
now see consistent "enterprise plan" messaging in the environment switch
tooltip.

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/16900241210>
> Commit: a462cb0
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=16900241210&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Tue, 12 Aug 2025 06:34:15 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Style**
* Updated tooltip messaging to display "enterprise plan" instead of
"business edition" in relevant user interface areas (environment
switcher and data-filter tooltips). This changes only the displayed plan
name in upgrade/locked-feature tooltips across the app. No changes to
feature availability or workflows.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@btsgh btsgh requested a review from laveena-en August 21, 2025 12:06
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 21, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (2)
  • pg
  • release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch release

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@btsgh btsgh merged commit 6cc9e9a into master Aug 21, 2025
324 of 330 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants