-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Daily Promotion - 21/08 #41186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Daily Promotion - 21/08 #41186
Conversation
…xed height container (#41178) ## Description Removing a line of code to fix extra space issue on Page with Fixed height container once switched from a Page with Auto height container. Also, manually tested out all issues from [#19082](#19082) to confirm nothing else breaks from the time these lines were added in the code. Fixes [#41180](#41180) ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/17043252133> > Commit: c8bde12 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=17043252133&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Mon, 18 Aug 2025 17:04:42 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Improved main container auto-height calculation to eliminate unintended extra spacing, resulting in more accurate, content-driven sizing. * **Chores** * Added diagnostic logging around main container size computation in view mode to aid troubleshooting (no functional impact). <!-- end of auto-generated comment: release notes by coderabbit.ai -->
…lan (#41168) ## Summary Updates the tooltip text for disabled environment switching to reference "enterprise plan" instead of "business plan" to align with current product terminology. ## Changes - Added new `ENTERPRISE_EDITION_TEXT` constant in `ce/constants/messages.ts` - Updated `SwitchEnvironment` component to use the new enterprise text constant - Maintains backward compatibility by keeping the original `BUSINESS_EDITION_TEXT` constant ## Files Changed - `app/client/src/ce/constants/messages.ts` - Added new enterprise text constant - `app/client/src/ce/components/SwitchEnvironment/index.tsx` - Updated tooltip to use enterprise terminology ## Testing - [ ] Verify tooltip displays "enterprise plan" text when environment switching is disabled - [ ] Confirm tooltip link functionality remains unchanged ## Impact This is a minor UI text update with no functional changes. Users will now see consistent "enterprise plan" messaging in the environment switch tooltip. ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/16900241210> > Commit: a462cb0 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=16900241210&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Tue, 12 Aug 2025 06:34:15 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Style** * Updated tooltip messaging to display "enterprise plan" instead of "business edition" in relevant user interface areas (environment switcher and data-filter tooltips). This changes only the displayed plan name in upgrade/locked-feature tooltips across the app. No changes to feature availability or workflows. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (2)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
Description
Tip
Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).
Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.
Fixes #
Issue Numberor
Fixes
Issue URLWarning
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Automation
/ok-to-test tags=""
🔍 Cypress test results
Caution
If you modify the content in this section, you are likely to disrupt the CI result for your PR.
Communication
Should the DevRel and Marketing teams inform users about this change?