Skip to content

27/10 Daily Promotion #41319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
btsgh merged 2 commits into from
Oct 27, 2025
Merged

27/10 Daily Promotion #41319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb723a7
fix: handle potential null basePageId in URL generation (#41315)
jacquesikot Oct 23, 2025
506d124
fix: ensure applications display correctly when AI agent flags are pa…
jacquesikot Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/client/src/ce/pages/Applications/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -929,7 +929,7 @@ export function ApplicationsSection(props: any) {
<ResourceListLoader isMobile={isMobile} resources={applications} />
) : (
<>
{!isAiAgentInstanceEnabled && (
{(!isAiAgentInstanceEnabled || !isAiAgentFlowEnabled) && (
<ApplicationCardList
applications={nonAnvilApplications}
canInviteToWorkspace={canInviteToWorkspace}
Expand All @@ -946,7 +946,7 @@ export function ApplicationsSection(props: any) {
workspaceId={activeWorkspace.id}
/>
)}
{isAiAgentFlowEnabled && (
{isAiAgentFlowEnabled && isAiAgentInstanceEnabled && (
<ApplicationCardList
applications={anvilApplications}
canInviteToWorkspace={canInviteToWorkspace}
Expand Down
2 changes: 1 addition & 1 deletion app/client/src/pages/AppIDE/layouts/components/Header/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ const Header = () => {
);

const deployLink = useHref(viewerURL, {
basePageId: currentPage?.basePageId,
basePageId: currentPage?.basePageId || null,
});

const updateApplicationDispatch = (
Expand Down
10 changes: 9 additions & 1 deletion app/client/src/pages/Editor/utils.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,15 @@ export function useHref<T extends URLBuilderParams>(
const pageId = useSelector(getCurrentPageId);

useEffect(() => {
if (pageId) setHref(urlBuilderFn(params));
if (pageId) {
try {
setHref(urlBuilderFn(params));
} catch (error) {
// If basePageId is not available yet, keep href as empty string
// This can happen during initial page load or navigation
setHref("");
}
}
}, [params, urlBuilderFn, pageId]);

return href;
Expand Down
Loading