forked from renatolond/pronto-ruby
-
Notifications
You must be signed in to change notification settings - Fork 0
update our pronto-ruby to the latest (based on Renato's work) #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
108d0aa
Add Hadolint configuration and linting workflow
Dakad 9038bbf
Add GitHub Actions workflow for Docker image build and publish
Dakad 98f5021
update our pronto-ruby to the latest (based on Renato's work)
kevin-tricot 009afde
remove rubocop-capybara
kevin-tricot b470e43
add back rubocop-capybara
kevin-tricot aa8ebde
Update Dockerfile and Gemfile.lock for Ruby and Bundler versions
Dakad a9bf0a7
Merge remote-tracking branch 'origin/devex/update_to_the_latest' into…
Dakad 619cb8e
Merge pull request #15 from apptweak/misc/davida/add-gh-action-to-pub…
Dakad ddbaee1
Bump all gems with minor changes, skipped the major bumps
Dakad ab99f11
Fix hadolint complaints
Dakad File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| name: Build and publish docker image | ||
| on: | ||
| workflow_dispatch: | ||
| push: | ||
| branches: | ||
| - main | ||
| - use_head_commit | ||
| tags: | ||
| # any tag names starting with 'v' | ||
| - 'v*' | ||
| env: | ||
| REGISTRY: ghcr.io | ||
| IMAGE_NAME: ${{ github.repository }} | ||
|
|
||
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: read | ||
| # Gives the action the ability to mint the OIDC token necessary to request a Sigstore signing certificate | ||
| id-token: write | ||
| # Permission necessary to persist the attestation | ||
| attestations: write | ||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
| - name: Set-up Docker Buildx | ||
| uses: docker/setup-buildx-action@v3 | ||
| with: | ||
| platforms: linux/amd64 | ||
| - name: Log in to the Github Container registry | ||
| uses: docker/login-action@v3 | ||
| with: | ||
| registry: ${{ env.REGISTRY }} | ||
| username: ${{ github.actor }} | ||
| password: ${{ secrets.GITHUB_TOKEN }} | ||
| - name: Extract metadata (tags, labels) for Docker | ||
| id: meta | ||
| uses: docker/metadata-action@v5 | ||
| with: | ||
| images: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }} | ||
| tags: | | ||
| type=ref,event=branch | ||
| type=ref,event=pr | ||
| type=semver,pattern={{version}} | ||
| type=semver,pattern={{major}}.{{minor}} | ||
| - name: Build and push Docker image | ||
| id: push | ||
| uses: docker/build-push-action@v6 | ||
| with: | ||
| context: . | ||
| push: true | ||
| tags: ${{ steps.meta.outputs.tags }} | ||
| labels: ${{ steps.meta.outputs.labels }} | ||
| - name: Generate artifact attestation | ||
| uses: actions/attest-build-provenance@v2 | ||
| with: | ||
| subject-name: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME}} | ||
| subject-digest: ${{ steps.push.outputs.digest }} | ||
| push-to-registry: true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| name: Hadolint - Dockerfile linting | ||
| on: | ||
| workflow_dispatch: | ||
| pull_request: | ||
| types: [opened, synchronize] | ||
| paths: | ||
| - "Dockerfile" | ||
| jobs: | ||
| hadolint: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: hadolint/hadolint-action@v3.1.0 | ||
| with: | ||
| verbose: true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| name: Specs | ||
|
|
||
| on: | ||
| push: | ||
|
|
||
| jobs: | ||
| spec: | ||
|
|
||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Install packages | ||
| run: sudo apt-get update && sudo apt-get install --no-install-recommends -y libjemalloc2 | ||
| - uses: actions/checkout@v6 | ||
| - name: Set up Ruby | ||
| # To automatically get bug fixes and new Ruby versions for ruby/setup-ruby, | ||
| # change this to (see https://github.com/ruby/setup-ruby#versioning): | ||
| uses: ruby/setup-ruby@v1 | ||
| with: | ||
| bundler-cache: true # runs 'bundle install' and caches installed gems automatically | ||
| - name: Unpack test repo | ||
| run: cd spec/fixtures && tar -zxf test.git.tar.gz | ||
| - name: Run tests | ||
| run: bundle exec rspec |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| # list of rules: https://github.com/hadolint/hadolint/wiki | ||
| ignored: | ||
| - DL3008 # Pin versions in apt-get install - https://github.com/hadolint/hadolint/wiki/DL3008 | ||
| # - DL3018 # Pin versions in apk add - https://github.com/hadolint/hadolint/wiki/DL3018 | ||
| # - DL3028 # Pin version in gem install - https://github.com/hadolint/hadolint/wiki/DL3028 | ||
|
|
||
| trustedRegistries: | ||
| - docker.io | ||
| - "*.gcr.io" | ||
| - "*.ecr.eu-west-1.amazonaws.com" | ||
|
|
||
| override: | ||
| warning: | ||
| - DL3028 # Pin version in gem install - https://github.com/hadolint/hadolint/wiki/DL3028 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| plugins: | ||
| - rubocop-capybara | ||
| - rubocop-factory_bot | ||
| - rubocop-minitest | ||
| - rubocop-performance | ||
| - rubocop-rake | ||
| - rubocop-sequel | ||
| - rubocop-yard | ||
|
|
||
| AllCops: | ||
| NewCops: enable | ||
| DisplayStyleGuide: true | ||
|
|
||
| Metrics: | ||
| Enabled: false | ||
|
|
||
| Layout/LineLength: | ||
| Enabled: false | ||
|
|
||
| # Align `end` with the matching keyword or starting expression except for | ||
| # assignments, where it should be aligned with the LHS. | ||
| Layout/EndAlignment: | ||
| EnforcedStyleAlignWith: variable | ||
|
|
||
| # Method definitions after `private` or `protected` isolated calls need one | ||
| # extra level of indentation. | ||
| Layout/IndentationConsistency: | ||
| EnforcedStyle: indented_internal_methods | ||
|
|
||
| Style/FrozenStringLiteralComment: | ||
| EnforcedStyle: always | ||
|
|
||
| # Use `foo { bar }` not `foo {bar}`. | ||
| Layout/SpaceInsideBlockBraces: | ||
| EnforcedStyleForEmptyBraces: space | ||
|
|
||
| # Check quotes usage according to lint rule below. | ||
| Style/StringLiterals: | ||
| EnforcedStyle: double_quotes | ||
|
|
||
| Style/RedundantReturn: | ||
| AllowMultipleReturnValues: true | ||
|
|
||
| Style/Semicolon: | ||
| AllowAsExpressionSeparator: true | ||
|
|
||
| Style/StringLiteralsInInterpolation: | ||
| EnforcedStyle: double_quotes | ||
|
|
||
| Style/RescueStandardError: | ||
| EnforcedStyle: implicit | ||
|
|
||
| Style/SymbolArray: | ||
| MinSize: 1 | ||
|
|
||
| Style/DocumentationMethod: | ||
| Enabled: true | ||
| RequireForNonPublicMethods: true | ||
|
|
||
| YARD/MismatchName: | ||
| EnforcedStylePrototypeName: before |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 3.3.7 | ||
| 3.4.8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.