fix: ConfigurationThreshold ignored#1730
Merged
gambol99 merged 5 commits intoappvia:developfrom Jan 5, 2026
Merged
Conversation
Bumping the values for the next release
…in permissions (appvia#1674) Signed-off-by: Rohith Jayawardene <gambol99@gmail.com> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…in permissions (appvia#1676) Signed-off-by: Rohith Jayawardene <gambol99@gmail.com> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
* Fix configuration IsRevisioned logic * Fix logic setting revision in state
gambol99
approved these changes
Jan 5, 2026
Member
gambol99
left a comment
gambol99
left a comment
There was a problem hiding this comment.
LGTM - thank you kindly @ronaldvb-k … I’ll cut this into a release shortly
gambol99
added a commit
that referenced
this pull request
Jan 22, 2026
* [HELM] - Release v0.5.6 (#1673) Bumping the values for the next release * Potential fix for code scanning alert no. 21: Workflow does not contain permissions (#1674) Signed-off-by: Rohith Jayawardene <gambol99@gmail.com> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> * Potential fix for code scanning alert no. 20: Workflow does not contain permissions (#1676) Signed-off-by: Rohith Jayawardene <gambol99@gmail.com> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> * Fix CloudResource unable to provision (#1689) * Fix configuration IsRevisioned logic * Fix logic setting revision in state * fix: ConfigurationThreshold ignored --------- Signed-off-by: Rohith Jayawardene <gambol99@gmail.com> Co-authored-by: Rohith Jayawardene <gambol99@gmail.com> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Co-authored-by: chris-brindley <chris.brindley@ovo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ConfigurationThresholdparameter is ignored because it is not passed intoconfiguration.Controller.The logs now indicate that it is working after the change: