Skip to content

chore: deployment page title #1980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: deployment page title #1980

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions ...ct-[region]-[project]/functions/function-[function]/deployment-[deployment]/header.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,15 @@
import { page } from '$app/state';
import { Id } from '$lib/components';
import { Cover, CoverTitle } from '$lib/layout';
import { func } from '../store';
import { deployment } from './store';

$: projectId = page.params.project;
$: functionId = page.params.function;
</script>

<Cover>
<svelte:fragment slot="header">
<CoverTitle
href={`${base}/project-${page.params.region}-${projectId}/functions/function-${functionId}`}>
Deployment
href={`${base}/project-${page.params.region}-${page.params.project}/functions/function-${page.params.function}`}>
{$func.name}'s deployment
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if the name is looong?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CoverTitle component truncates long text

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but that would also truncate the text deployment as well right? 👀
Shouldn't the deployment page's title should mention deployment?

LoremIpsumLongFunctio's deployment > LoremIpsum...

isn't that same as function's title then?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's the downside of adding the function/site name... you can bring it up with design on discord

</CoverTitle>
<Id value={$deployment.$id}>{$deployment.$id}</Id>
</svelte:fragment>
Expand Down
3 changes: 2 additions & 1 deletion ...ct-[region]-[project]/sites/site-[site]/deployments/deployment-[deployment]/header.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,15 @@
import { page } from '$app/state';
import { Id } from '$lib/components';
import { Cover, CoverTitle } from '$lib/layout';
import { site } from '../../store';
import { deployment } from './store';
</script>

<Cover>
<svelte:fragment slot="header">
<CoverTitle
href={`${base}/project-${page.params.region}-${page.params.project}/sites/site-${page.params.site}/deployments`}>
Deployment
{$site.name}'s deployment
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same.

</CoverTitle>
<Id value={$deployment.$id}>{$deployment.$id}</Id>
</svelte:fragment>
Expand Down