Skip to content

Fix: display version in the footer on local instance #2101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tejas-raskar
Copy link

What does this PR do?

Displays the current version in the footer on local instances similar to that on cloud instances.

Test Plan

  • Ran pnpm run tests, pnpm run checks, pnpm run lint, and pnpm run format to maintain the code quality.
  • Verified using separate browsers to confirm the changes work as expected. Here are the results -

Desktop view:
Screenshot From 2025-07-10 00-55-33

For $isSmallViewport, I tried to maintain the same design as that of the cloud version. The version is shown on the separate line instead of the same line as desktop view.

Mobile view:
Screenshot From 2025-07-10 00-55-55

Related PRs and Issues

Fixes #1997

Have you read the Contributing Guidelines on issues?

Yes

@coolify-appwrite-org
Copy link

coolify-appwrite-org bot commented Jul 9, 2025

The preview deployment is ready. 🟢

Open Preview | Open Build Logs

Last updated at: 2025-07-25 14:15:05 CET

@coolify-appwrite-org
Copy link

coolify-appwrite-org bot commented Jul 9, 2025

The preview deployment is ready. 🟢

Open Preview | Open Build Logs

Last updated at: 2025-07-25 14:15:09 CET

@ChiragAgg5k ChiragAgg5k requested a review from Copilot July 17, 2025 13:54
Copilot

This comment was marked as outdated.

@docimin
Copy link

docimin commented Jul 17, 2025

Maybe it's a smart idea to put the version to the right of Privacy, instead of below, as well as remove the seperator in mobile, so this actually looks mobile friendly?
image

@tejas-raskar
Copy link
Author

I tried to keep it consistent with the cloud version. But I too think version besides Privacy is a good idea. This is how the cloud version looks like:

image

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the version display in the footer to show on local instances, not just cloud instances. The changes restructure the conditional rendering logic to ensure version information appears consistently across both deployment types while maintaining responsive design.

  • Removes the cloud-only restriction for version display in small viewports
  • Reorganizes the layout structure to properly handle version display for both cloud and local instances
  • Maintains existing responsive behavior and visual design patterns

</Link.Anchor>
<span class="divider-wrapper">
<Divider vertical />
</span>
{/if}
{/if}
Copy link
Preview

Copilot AI Jul 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This closing {/if} statement appears to be misplaced or unmatched. Based on the diff context, it should correspond to the {#if !$isSmallViewport} condition that opens at line 85, but the indentation and logical flow suggest a structural issue in the conditional blocks.

Copilot uses AI. Check for mistakes.

@HarshMN2345 HarshMN2345 self-requested a review July 18, 2025 12:52
@HarshMN2345
Copy link
Member

@tejas-raskar Thanks for the PR! We'll confirm with our design team and get back to you shortly. Appreciate your contribution! 🙌

@HarshMN2345
Copy link
Member

HarshMN2345 commented Jul 24, 2025

I tried to keep it consistent with the cloud version. But I too think version besides Privacy is a good idea. This is how the cloud version looks like:

image

Hey @tejas-raskar,
I checked with the design team and they suggested a small improvement, can we make it a bit smarter so that the version only moves to the next line if there's not enough space to keep it in the first row?

Instead of always rendering the version on a new line for small viewports, we could improve the layout by letting it stay in the first row unless there isn’t enough space.

@tejas-raskar
Copy link
Author

@HarshMN2345 Great! I will do the required changes and commit it on this branch itself.
Thanks for confirming.

@tejas-raskar tejas-raskar force-pushed the fix-1997-bring-back-the-current-version-in-the-footer branch from 29fbdec to cba8d2c Compare July 25, 2025 14:11
@tejas-raskar
Copy link
Author

I made the version inline with the other links as requested and also added the wrap prop to make the footer wrap around when the text overflows.

Screencast.From.2025-07-25.19-28-42.mp4

@tejas-raskar
Copy link
Author

@HarshMN2345 The test is failing due to some other errors in files that are not touched by this PR. I can only see one warning relevant to this PR which is removing of the unused CSS. How should I proceed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Enhancement: Bring back the current Version in the footer
3 participants