Skip to content

chore: update the text below CNAME config errors #2458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: update the text below CNAME config errors #2458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions src/lib/components/domains/cnameAlert.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
<script lang="ts">
import { Link } from '$lib/elements';
import { Alert, InlineCode } from '@appwrite.io/pink-svelte';
</script>

<Alert.Inline>
<p>
If your domain uses CAA records, ensure there is an <InlineCode code="issue" /> policy for <InlineCode
code="certainly.com" /> - otherwise, SSL setup may fail.
</p>
<br />
Copy link

Copilot AI Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using <br /> for spacing is not a best practice. Consider using CSS margins or padding, or wrapping the content in separate elements with appropriate spacing.

Copilot uses AI. Check for mistakes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, @stnguyen90 you can use a Layout.Stack if needed for adding space between contents 👍

<p>
A list of all domain providers and their DNS setting is available <Link
variant="muted"
external
href="https://appwrite.io/docs/advanced/platform/custom-domains">here</Link
>.
</p>
</Alert.Inline>
21 changes: 3 additions & 18 deletions src/lib/components/domains/cnameTable.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,7 @@
<script lang="ts">
import { Link } from '$lib/elements';
import { IconInfo } from '@appwrite.io/pink-icons-svelte';
import {
Badge,
Layout,
Typography,
Table,
Icon,
InteractiveText
} from '@appwrite.io/pink-svelte';
import { Badge, Layout, Typography, Table, InteractiveText } from '@appwrite.io/pink-svelte';
import { regionalConsoleVariables } from '$routes/(console)/project-[region]-[project]/store';
import CnameAlert from './cnameAlert.svelte';

export let domain: string;
export let verified = undefined;
Expand Down Expand Up @@ -53,13 +45,6 @@
</Table.Row.Base>
</Table.Root>
<Layout.Stack gap="s" direction="row" alignItems="center">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we probably don't need this stack here.

<Icon icon={IconInfo} size="s" color="--fgcolor-neutral-secondary" />
<Typography.Text variant="m-400" color="--fgcolor-neutral-secondary">
A list of all domain providers and their DNS setting is available <Link
variant="muted"
external
href="https://appwrite.io/docs/advanced/platform/custom-domains">here</Link
>.
</Typography.Text>
<CnameAlert />
</Layout.Stack>
</Layout.Stack>
19 changes: 3 additions & 16 deletions src/lib/components/domains/recordTable.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,8 @@
<script lang="ts">
import { Link } from '$lib/elements';
import {
Badge,
Layout,
Typography,
Table,
InteractiveText,
Alert
} from '@appwrite.io/pink-svelte';
import { Badge, Layout, Typography, Table, InteractiveText } from '@appwrite.io/pink-svelte';
import { regionalConsoleVariables } from '$routes/(console)/project-[region]-[project]/store';
import CnameAlert from './cnameAlert.svelte';

export let domain: string;
export let verified = undefined;
Expand Down Expand Up @@ -65,14 +59,7 @@
</Table.Root>
<Layout.Stack gap="s" direction="row" alignItems="center">
{#if variant === 'cname'}
<Alert.Inline>
If your domain uses CAA records, ensure certainly.com is authorized — otherwise, SSL
setup may fail. A list of all domain providers and their DNS setting is available <Link
variant="muted"
external
href="https://appwrite.io/docs/advanced/platform/custom-domains">here</Link
>.
</Alert.Inline>
<CnameAlert />
{:else}
<Typography.Text variant="m-400" color="--fgcolor-neutral-secondary">
A list of all domain providers and their DNS setting is available <Link
Expand Down
12 changes: 2 additions & 10 deletions ...sole)/project-[region]-[project]/functions/function-[function]/domains/recordsCard.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,15 @@
<script lang="ts">
import { Link } from '$lib/elements';
import { IconInfo } from '@appwrite.io/pink-icons-svelte';
import {
Badge,
Layout,
Typography,
Table,
Fieldset,
Icon,
InteractiveText
} from '@appwrite.io/pink-svelte';
import type { Models } from '@appwrite.io/console';
import { regionalConsoleVariables } from '$routes/(console)/project-[region]-[project]/store';
import CnameAlert from '$lib/components/domains/cnameAlert.svelte';

export let proxyRule: Models.ProxyRule;
</script>
Expand Down Expand Up @@ -48,13 +46,7 @@
</Table.Row.Base>
</Table.Root>
<Layout.Stack gap="s" direction="row" alignItems="center">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above for stack.

<Icon icon={IconInfo} size="s" color="--fgcolor-neutral-secondary" />
<Typography.Text variant="m-400" color="--fgcolor-neutral-secondary">
A list of all domain providers and their DNS setting is available <Link
variant="muted"
href="#">here</Link
>.
</Typography.Text>
<CnameAlert />
</Layout.Stack>
</Layout.Stack>
<slot />
Expand Down