Skip to content

Fix: issues in sites build settings #2770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HarshMN2345 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix: issues in sites build settings #2770

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e5d9ce
added fallback commands in config
HarshMN2345 Jan 7, 2026
209744e
default fallback for site settings
HarshMN2345 Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/routes/(console)/project-[region]-[project]/sites/create-site/configuration.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,8 @@
id="installCommand"
label="Install command"
bind:value={installCommand}
placeholder={adapterData?.installCommand} />
placeholder={adapterData?.installCommand ||
'Enter install command'} />
<Button
secondary
size="s"
Expand All @@ -109,7 +110,7 @@
id="buildCommand"
label="Build command"
bind:value={buildCommand}
placeholder={adapterData?.buildCommand} />
placeholder={adapterData?.buildCommand || 'Enter build command'} />
<Button
secondary
size="s"
Expand All @@ -123,7 +124,8 @@
id="outputDirectory"
label="Output directory"
bind:value={outputDirectory}
placeholder={adapterData?.outputDirectory} />
placeholder={adapterData?.outputDirectory ||
'Enter output directory'} />
<Button
secondary
size="s"
Expand Down
2 changes: 1 addition & 1 deletion src/routes/(console)/project-[region]-[project]/sites/create-site/manual/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@
<Layout.Stack alignItems="center" gap="s">
<Layout.Stack alignItems="center" justifyContent="center" inline>
<Typography.Text variant="l-500" align="center" inline>
Drag and drop file here or click to upload;
Drag and drop file here or click to upload
<Layout.Stack
style="display: inline-flex; vertical-align: middle;"
inline
Expand Down
6 changes: 3 additions & 3 deletions ...console)/project-[region]-[project]/sites/site-[site]/settings/updateBuildSettings.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,9 @@
$effect(() => {
if (adapter === Adapter.Static) {
if (!fallback) {
fallback ||= selectedFramework.adapters.find(
(a) => a.key === Adapter.Static
).fallbackFile;
fallback ||=
selectedFramework.adapters.find((a) => a.key === Adapter.Static)
?.fallbackFile || 'index.html';
}
}
});
Expand Down