Skip to content

Conversation

@ChiragAgg5k
Copy link
Member

@ChiragAgg5k ChiragAgg5k commented Jan 16, 2026

Summary

  • Adds executionTimeout.ts helper (similar to existing buildTimeout.ts) to detect stuck executions
  • Executions in 'waiting' or 'processing' state beyond the function's timeout are displayed as 'failed'
  • Updates both the executions table and sheet views to use the effective status

Test plan

  • Navigate to a function's executions page
  • Verify executions that have exceeded the function's timeout while stuck in 'waiting' or 'processing' show as 'failed'
  • Verify normal executions display their correct status
  • Verify the execution detail sheet also shows the correct effective status

Summary by CodeRabbit

  • Chores

    • Updated SvelteKit framework dependency to a newer stable version.
  • New Features

    • Execution status displays now account for function timeouts in execution monitoring views.

✏️ Tip: You can customize this high-level summary in your review settings.

Similar to buildTimeout.ts, this adds executionTimeout.ts to detect
executions stuck in 'waiting' or 'processing' state beyond the
function's configured timeout, displaying them as 'failed'.
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 16, 2026

Warning

Rate limit exceeded

@ChiragAgg5k has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 12 minutes and 45 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 407123e and a35a526.

📒 Files selected for processing (2)
  • src/lib/helpers/buildTimeout.ts
  • src/lib/helpers/executionTimeout.ts

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Walkthrough

This pull request updates the devDependency @sveltejs/kit from ^2.42.1 to ^2.49.5, adds a new helper src/lib/helpers/executionTimeout.ts providing getEffectiveExecutionStatus to treat timed-out executions as failed, and updates two UI components (sheet.svelte and table.svelte) to use this effective status for tooltip logic, status display, and timer rendering instead of the raw execution status field.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main change: adding an execution timeout helper to display stuck executions as failed, which matches the primary objective of the pull request.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds functionality to detect and display executions that have exceeded their function's timeout while stuck in 'waiting' or 'processing' states. The implementation follows the existing buildTimeout.ts pattern and correctly applies the timeout logic to both the executions table and detail sheet views.

Changes:

  • Added executionTimeout.ts helper to calculate effective execution status based on timeout
  • Updated executions table to display timed-out executions as 'failed'
  • Updated execution detail sheet to use the effective status for display and duration calculation

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 4 comments.

File Description
src/lib/helpers/executionTimeout.ts New helper module implementing timeout detection logic for executions
src/routes/(console)/project-[region]-[project]/functions/function-[function]/executions/table.svelte Updated to use effective execution status in status display and duration timer conditions
src/routes/(console)/project-[region]-[project]/functions/function-[function]/executions/sheet.svelte Updated detail sheet to use effective execution status in status display and duration timer conditions
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

"@playwright/test": "^1.55.1",
"@sveltejs/adapter-static": "^3.0.8",
"@sveltejs/kit": "^2.42.1",
"@sveltejs/kit": "^2.49.5",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the bump?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

audit's failing

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2026-01-16 at 3 18 55 PM

The timer should continue running for executions stuck in processing/waiting
even when they're displayed as failed due to timeout.
@ChiragAgg5k ChiragAgg5k merged commit e36a4ec into main Jan 16, 2026
3 checks passed
@ChiragAgg5k ChiragAgg5k deleted the feat/execution-timeout-helper branch January 16, 2026 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants