-
Notifications
You must be signed in to change notification settings - Fork 208
Add execution timeout helper to show stuck executions as failed #2788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Similar to buildTimeout.ts, this adds executionTimeout.ts to detect executions stuck in 'waiting' or 'processing' state beyond the function's configured timeout, displaying them as 'failed'.
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughThis pull request updates the devDependency Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds functionality to detect and display executions that have exceeded their function's timeout while stuck in 'waiting' or 'processing' states. The implementation follows the existing buildTimeout.ts pattern and correctly applies the timeout logic to both the executions table and detail sheet views.
Changes:
- Added
executionTimeout.tshelper to calculate effective execution status based on timeout - Updated executions table to display timed-out executions as 'failed'
- Updated execution detail sheet to use the effective status for display and duration calculation
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/lib/helpers/executionTimeout.ts | New helper module implementing timeout detection logic for executions |
| src/routes/(console)/project-[region]-[project]/functions/function-[function]/executions/table.svelte | Updated to use effective execution status in status display and duration timer conditions |
| src/routes/(console)/project-[region]-[project]/functions/function-[function]/executions/sheet.svelte | Updated detail sheet to use effective execution status in status display and duration timer conditions |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...s/(console)/project-[region]-[project]/functions/function-[function]/executions/table.svelte
Outdated
Show resolved
Hide resolved
...s/(console)/project-[region]-[project]/functions/function-[function]/executions/sheet.svelte
Outdated
Show resolved
Hide resolved
| "@playwright/test": "^1.55.1", | ||
| "@sveltejs/adapter-static": "^3.0.8", | ||
| "@sveltejs/kit": "^2.42.1", | ||
| "@sveltejs/kit": "^2.49.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why the bump?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
audit's failing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The timer should continue running for executions stuck in processing/waiting even when they're displayed as failed due to timeout.

Summary
executionTimeout.tshelper (similar to existingbuildTimeout.ts) to detect stuck executionsTest plan
Summary by CodeRabbit
Chores
New Features
✏️ Tip: You can customize this high-level summary in your review settings.