Skip to content

Conversation

@HarshMN2345
Copy link
Member

@HarshMN2345 HarshMN2345 commented Jan 16, 2026

What does this PR do?

(Provide a description of what this PR does.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

Summary by CodeRabbit

  • Bug Fixes
    • Fixed deployment status display to correctly show "ready" for deployments that are currently finalizing, providing clearer status indication across deployment views.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 16, 2026

Walkthrough

Two deployment status display components are updated to normalize the 'finalizing' status value to 'ready' for UI rendering purposes. A computed displayStatus variable is introduced in both files, which maps 'finalizing' to 'ready' while preserving other status values unchanged. The status rendering logic is updated to use displayStatus instead of effectiveStatus for the status converter and label display, while the underlying effectiveStatus value remains unmodified.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: mapping the 'finalizing' deployment status to display as 'ready' instead, effectively removing the visible 'finalizing' status from the UI.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


🧹 Recent nitpick comments
src/routes/(console)/project-[region]-[project]/sites/site-[site]/deployments/table.svelte (1)

84-88: Consider centralizing the status normalization.

This mapping is duplicated in the overview table; a small helper (e.g., normalizeDeploymentStatus) would prevent drift.


📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0f80efe and c3388c7.

📒 Files selected for processing (2)
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/deployments/table.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/deploymentsOverview.svelte
🧰 Additional context used
📓 Path-based instructions (5)
**/*.{ts,tsx,js,jsx,svelte}

📄 CodeRabbit inference engine (AGENTS.md)

**/*.{ts,tsx,js,jsx,svelte}: Import reusable modules from the src/lib directory using the $lib alias
Use minimal comments in code; reserve comments for TODOs or complex logic explanations
Use $lib, $routes, and $themes aliases instead of relative paths for module imports

Files:

  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/deploymentsOverview.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/deployments/table.svelte
src/routes/**/*.svelte

📄 CodeRabbit inference engine (AGENTS.md)

Use SvelteKit file conventions: +page.svelte for components, +page.ts for data loaders, +layout.svelte for wrappers, +error.svelte for error handling, and dynamic route params in square brackets like [param]

Files:

  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/deploymentsOverview.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/deployments/table.svelte
**/*.{ts,tsx,js,jsx,svelte,json}

📄 CodeRabbit inference engine (AGENTS.md)

Use 4 spaces for indentation, single quotes, 100 character line width, and no trailing commas per Prettier configuration

Files:

  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/deploymentsOverview.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/deployments/table.svelte
**/*.svelte

📄 CodeRabbit inference engine (AGENTS.md)

Use Svelte 5 + SvelteKit 2 syntax with TypeScript for component development

Files:

  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/deploymentsOverview.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/deployments/table.svelte
src/routes/**

📄 CodeRabbit inference engine (AGENTS.md)

Configure dynamic routes using SvelteKit convention with [param] syntax in route directory names

Files:

  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/deploymentsOverview.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/deployments/table.svelte
🔇 Additional comments (2)
src/routes/(console)/project-[region]-[project]/sites/site-[site]/deployments/table.svelte (1)

84-105: Good normalization for UI rendering.

Clear separation between effectiveStatus and displayStatus, and the UI now consistently reflects the normalized value.

src/routes/(console)/project-[region]-[project]/sites/site-[site]/deploymentsOverview.svelte (1)

69-87: Status display uses normalized value consistently.

The UI now aligns with the desired “finalizing → ready” presentation.

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@HarshMN2345 HarshMN2345 merged commit b7e0284 into main Jan 16, 2026
3 checks passed
@HarshMN2345 HarshMN2345 deleted the fix-remove-finalising-status-from-sites branch January 16, 2026 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants