Skip to content

Fix: number input bigint and cleanup #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HarshMN2345 wants to merge 2 commits into
base: next
Choose a base branch
from
Open

Fix: number input bigint and cleanup #402

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b8ab04
fix(Number): keep bigint type in bigint mode, fix decrement keydown, …
HarshMN2345 Feb 15, 2026
78bd858
Merge branch 'next' into fix/number-input-bigint-and-cleanup
HarshMN2345 Feb 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
86 changes: 44 additions & 42 deletions v2/pink-sb/src/lib/input/Number.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,15 @@
let bigintMode = false;
let minAttr: NativeNumber = undefined;
let maxAttr: NativeNumber = undefined;
let inputValue = '';

let input: HTMLInputElement;
const dispatch = createEventDispatcher();

$: if (typeof value === 'bigint' || typeof value === 'number') {
bigintMode = typeof value === 'bigint';
$: bigintMode = typeof value === 'bigint';

function valueToDisplayString(v: ExtendedNumber): string {
return v === null || v === undefined ? '' : v.toString();
}

function toNumberInputBound(raw: ExtendedNumber): NativeNumber {
Expand Down Expand Up @@ -80,66 +83,64 @@
$: maxAttr = bigintMode ? undefined : toNumberInputBound(max);

function fireOnChangeDispatch(next: ExtendedNumber) {
let current = next;

if (bigintMode) {
const parsed = parseBigIntValue(current);
value = parsed ?? current;
const parsed = parseBigIntValue(next);
value = parsed ?? value;
inputValue = valueToDisplayString(value);
dispatch('change', parsed ?? undefined);
return;
}
const num = Number(current);
value = Number.isNaN(num) ? current : num;
const num = Number(next);
value = Number.isNaN(num) ? next : num;
dispatch('change', Number.isNaN(num) ? undefined : num);
}

function increment(): void {
if (bigintMode) {
const stepValue = parseBigIntStep(step);
const current = parseBigIntValue(value) ?? 0n;
const minValue = parseBigIntBound(min);
const maxValue = parseBigIntBound(max);
let next = current + stepValue;

if (minValue !== null && next < minValue) {
next = minValue;
}
function clampBigInt(val: bigint, minVal: bigint | null, maxVal: bigint | null): bigint {
let result = val;
if (minVal !== null && result < minVal) result = minVal;
if (maxVal !== null && result > maxVal) result = maxVal;
return result;
}

if (maxValue !== null && next > maxValue) {
next = maxValue;
}
function stepBigInt(direction: 1 | -1): void {
const stepValue = parseBigIntStep(step);
const current = parseBigIntValue(value) ?? 0n;
const bounds = { min: parseBigIntBound(min), max: parseBigIntBound(max) };
const next = clampBigInt(
current + (direction === 1 ? stepValue : -stepValue),
bounds.min,
bounds.max
);
fireOnChangeDispatch(next);
}

fireOnChangeDispatch(next);
function increment(): void {
if (bigintMode) {
stepBigInt(1);
return;
}

input.stepUp();
fireOnChangeDispatch(input.value);
}

function decrement(): void {
if (bigintMode) {
const stepValue = parseBigIntStep(step);
const current = parseBigIntValue(value) ?? 0n;
const minValue = parseBigIntBound(min);
const maxValue = parseBigIntBound(max);
let next = current - stepValue;

if (minValue !== null && next < minValue) {
next = minValue;
}

if (maxValue !== null && next > maxValue) {
next = maxValue;
}

fireOnChangeDispatch(next);
stepBigInt(-1);
return;
}

input.stepDown();
fireOnChangeDispatch(input.value);
}

function handleBigIntInput(e: Event & { currentTarget: EventTarget & HTMLInputElement }) {
const raw = e.currentTarget.value;
fireOnChangeDispatch(raw);
inputValue = raw;
}

$: if (bigintMode) {
inputValue = valueToDisplayString(value);
}
</script>

<Base {id} {label} {helper} {state} {required} {leadingIcon}>
Expand All @@ -161,7 +162,8 @@
on:invalid
on:change={() => fireOnChangeDispatch(input.value)}
bind:this={input}
bind:value
value={inputValue}
on:input={handleBigIntInput}
type="text"
inputmode="numeric"
{disabled}
Expand Down Expand Up @@ -206,7 +208,7 @@
<button
disabled={disabled || readonly}
on:mousedown={decrement}
on:keydown={increment}
on:keydown={decrement}
tabindex="-1"
type="button"
>
Expand Down