fix(models): tolerate $sequence
int/string/null in Document.fromMap
#262
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
"$sequence"
is returned as a string or omitted.Document.$sequence
to nullable (int?
) and parses with:$sequence: (map['\$sequence'] as num?)?.toInt(),
Null → int
andString → int
errors duringfromMap
.Test Plan
"$sequence": "3"
→doc.$sequence == 3
"$sequence"
→doc.$sequence == null
dart format .
dart analyze
flutter test
Related PRs and Issues
Notes
final int $sequence;
fromMap: $sequence: (map['\$sequence'] as num?)?.toInt() ?? 0,
which preserves the API and defaults missing values to 0.
Have you read the Contributing Guidelines on issues?
Yes.