chore: fix updatePrefs not working with new object based params #1144
+20
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
since for updatePrefs old method's first param was also an object, made the check a bit stricter to see if
prefs
exist in the object:still doesnt cover the edge case where
key
of the preferences is alsoprefs
... but the change is breaking 😅update deprecated message to be clearer with examples:
Test Plan
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
yes.