fix(dart/templates): tolerant int deserialization in models; make \$s… #1147
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
(map['$field'] as num?)?.toInt()
instead of assigning raw values."$sequence"
to be nullable in generated models to tolerate missing values.Why:
"$sequence"
as a string or omit it. Previous code causedString → int
andNull → int
runtime errors in generated SDKs.Test Plan
Document.fromMap
contains:$sequence: (map['\$sequence'] as num?)?.toInt(),
(nullable)?? 0
default when applicable.dart format .
dart analyze
flutter test
on generated SDK"$sequence"
and with"$sequence": "3"
; confirmed no crashes and correct values.Related PRs and Issues
Have you read the Contributing Guidelines on issues?
Yes.