-
Notifications
You must be signed in to change notification settings - Fork 197
Add Pydantic models and uv support to the Python SDK #1375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ChiragAgg5k
wants to merge
13
commits into
master
Choose a base branch
from
feat/python-pydantic-models
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+856
−81
Open
Changes from 6 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
cf4525e
Add Pydantic models and uv support to Python SDK
ChiragAgg5k 0e70dc8
Fix Python generator typing edge cases
ChiragAgg5k 9aed965
Wrap Python service template signatures
ChiragAgg5k 503beb0
Update Python SDK tests for typed model responses
ChiragAgg5k b5c1d5d
Preserve nullable Python model property types
ChiragAgg5k 43546ba
Update Python docs examples for Pydantic models
ChiragAgg5k 4fdf6d8
Annotate typed Python docs example results
ChiragAgg5k 30e5134
Fix Python model serialization and docs collisions
ChiragAgg5k c56d645
make getResponseType collision aware
ChiragAgg5k dab82e9
feat: add Generic[T] support to Python SDK models
ChiragAgg5k 55f3229
formatting issue
ChiragAgg5k 604d389
formatting issue
ChiragAgg5k 202edda
lint
ChiragAgg5k File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,24 @@ | ||
| return self.client.call('{{ method.method | caseLower }}', api_path, { | ||
| response = self.client.call('{{ method.method | caseLower }}', api_path, { | ||
| {% for parameter in method.parameters.header %} | ||
| '{{ parameter.name }}': {{ parameter.name | escapeKeyword | caseSnake }}, | ||
| '{{ parameter.name }}': self._normalize_value({{ parameter.name | escapeKeyword | caseSnake }}), | ||
| {% endfor %} | ||
| {% for key, header in method.headers %} | ||
| '{{ key }}': '{{ header }}', | ||
| {% endfor %} | ||
| }, api_params{% if method.type == 'webAuth' %}, response_type='location'{% endif %}) | ||
| }, api_params{% if method.type == 'webAuth' %}, response_type='location'{% endif %}) | ||
| {% if method.responseModels is defined and method.responseModels|length > 1 %} | ||
| {% set validResponseModels = [] %} | ||
| {% for responseModel in method.responseModels %} | ||
| {% if responseModel and responseModel != 'any' %} | ||
| {% set validResponseModels = validResponseModels|merge([responseModel]) %} | ||
| {% endif %} | ||
| {% endfor %} | ||
|
|
||
| return self._parse_response(response, union_models=({% for responseModel in validResponseModels %}{% if (responseModel | caseUcfirst) == (service.name | caseUcfirst) %}{{ responseModel | caseUcfirst }}Model{% else %}{{ responseModel | caseUcfirst }}{% endif %}, {% endfor %})) | ||
| {% elseif method.responseModel and method.responseModel != 'any' %} | ||
|
|
||
| return self._parse_response(response, model={% if (method.responseModel | caseUcfirst) == (service.name | caseUcfirst) %}{{ method.responseModel | caseUcfirst }}Model{% else %}{{ method.responseModel | caseUcfirst }}{% endif %}) | ||
| {% else %} | ||
|
|
||
| return response | ||
| {% endif %} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.