Skip to content

Fix(carousel): Simplify scrolling logic to fix arrow buttons #2212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix(carousel): Simplify scrolling logic to fix arrow buttons #2212

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bf0a4c7
fix(carousel): Simplify scrolling logic to fix arrow buttons
Mahavishnu-K Jul 24, 2025
53a238a
fix(carousel): Simplify scrolling logic to fix arrow buttons
Mahavishnu-K Jul 24, 2025
c5803ae
Merge branch 'main' into fix-carousel-scroll-logic
Mahavishnu-K Jul 24, 2025
e66d40a
Merge branch 'main' into fix-carousel-scroll-logic
ebenezerdon Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 2 additions & 17 deletions src/lib/components/Carousel.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,31 +11,16 @@
}

const { size = 'default', gap = 32, header, children }: Props = $props();
let scroll = 0;

function calculateScrollAmount(prev = false) {
const direction = prev ? -1 : 1;
const carouselSize = carousel?.clientWidth;
const childSize = (carousel.childNodes[0] as HTMLUListElement)?.clientWidth + gap;

scroll = scroll || carouselSize;

const numberOfItems = Math.floor(carouselSize / childSize);
const overflow = scroll % childSize;
const amount = numberOfItems * childSize - overflow * direction;
scroll += amount * direction;
return amount * direction;
}

function next() {
carousel.scrollBy({
left: calculateScrollAmount(),
left: carousel.clientWidth,
behavior: 'smooth'
});
}
function prev() {
carousel.scrollBy({
left: calculateScrollAmount(true),
left: -carousel.clientWidth,
behavior: 'smooth'
});
}
Expand Down