fix: handle base64 decoding properly in code preview components on function page #2217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appwrite.ioProject ID: Note Cursor pagination performs better than offset pagination when loading further pages. |
|
Hi @sara-k-48 @stnguyen90 👋, I’ve opened a PR to fix the issue #2180 on the Functions page. The decoding is now correctly handled using atob, ensuring the examples display properly. Whenever you get a chance, could you please take a look and let me know if any changes are needed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes issue: #2180 a decoding issue with base64-encoded code snippets in the following components:
MultiCodeContextless.svelteLanguages.svelteThe issue was reported in Issue #2180 where the actual content not rendered properly rather base64 content seen.
Test Plan
pnpm run dev&pnpm run buildUpdate:
decoded-fix-func.mp4
Related PRs and Issues
Closes #2180
Have you read the Contributing Guidelines on issues?
Yes