Skip to content

fix: duplicate testimonials in startup caraousal for infinite scroll #2401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: duplicate testimonials in startup caraousal for infinite scroll #2401

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 31 additions & 7 deletions src/routes/startups/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,13 +172,12 @@
'Thanks to Appwrite and advances in technology, we were able to get an MVP out in 2-3 months with 1 developer.',
'jonas-janssen'
),
testimonial(
'Zach Handley',
'CTO // Socialaize',
"We have somewhere between 200,000 to 600,000 function executions per day. It's especially nice that you guys have to deal with the scaling now and not me.",
'zach-handley'
),
mariusBolik
{
name: 'Zach Handley',
handle: 'CTO // Socialaize',
text: "We have somewhere between 200,000 to 600,000 function executions per day. It's especially nice that you guys have to deal with the scaling now and not me.",
image: '/images/testimonials/zach-handley.jpg'
}
Comment on lines +175 to +180
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why an object and not the testimonial method used like others?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by default it was .png, so image wasn’t rendering. This one’s .jpeg.

];
</script>

Expand Down Expand Up @@ -570,6 +569,31 @@
</div>
</li>
{/each}
{#each testimonials as t}
<li>
<div
class="web-card is-white web-u-margin-block-start-64 e-mt-12-mobile gap-5"
style="inline-size:23.625rem"
>
<p class="aw-sub-body-500">{t.text}</p>
<div class="web-user-box">
<img
class="web-user-box-image"
src={t.image}
alt="Avatar of Kap.ts"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong alt

width="48"
height="48"
/>
<div class="web-user-box-name text-sub-body font-medium">
{t.name}
</div>
<div class="web-user-box-username text-sub-body">
{t.handle}
</div>
</div>
</div>
</li>
{/each}
</ul>
</div>
</div>
Expand Down