Conversation
SergiusTheBest
left a comment
There was a problem hiding this comment.
Please, split it into 2 separate PRs and add tests for them.
|
This issue was detected by driver verifier. Should I create my own test for memory leaks? |
@Kellesi If existing tests trigger memory leak then there is no need in creating another test. |
@Kellesi What about this? |
|
@SergiusTheBest |
|
@Kellesi Mainly it's because one fix is good and can be merger right away and be used by other guys. And another fix requires further discussion. But we can do it later. They are both good enough to be merged. Thank you for the fix! 💪 |
Fix memory leaks in kf::map
Task: https://jira.dev.local/jira/browse/KF-20
Also faced to a little memory leak in kf::Bitmap and fixed it