Skip to content

fix memory leaks in map and bitmap #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SergiusTheBest merged 1 commit into from
Aug 4, 2025
Merged

fix memory leaks in map and bitmap #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions include/kf/Bitmap.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ namespace kf
{
if (&other != this)
{
deinitialize();
m_header = other.m_header;
other.m_header = {};
}
Expand Down
7 changes: 3 additions & 4 deletions include/kf/MapAllocator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,9 @@ namespace kf
return buffer;
}

void deallocate(T*, std::size_t)
void deallocate(T* buf, std::size_t)
{
m_state->buffer.reset();
m_state->size = 0;
delete buf;
}

[[nodiscard]] bool prepareMemory(std::size_t size)
Expand All @@ -70,7 +69,7 @@ namespace kf
return false;
}

if (m_state->buffer)
if (m_state->buffer && m_state->size == size)
{
return true;
}
Expand Down