Support class/struct that is convertible to NTSTATUS #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So we can use something smarter than a plain NTSTATUS as a return type.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the ScopeFailure utility to accept types that are convertible to NTSTATUS, rather than requiring plain NTSTATUS. This allows for more sophisticated return type patterns while maintaining backward compatibility with existing NTSTATUS usage.
Key Changes
- Templated
ScopeFailureandMakeScopeFailureclasses to accept any type convertible to NTSTATUS using C++20 concepts - Added explicit return type annotation to a lambda in
FltCommunicationPort.hfor clarity
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| include/kf/ScopeFailure.h | Added template parameter T with std::convertible_to<T, NTSTATUS> constraint to both ScopeFailure and MakeScopeFailure classes, replacing direct NTSTATUS usage |
| include/kf/FltCommunicationPort.h | Added explicit -> NTSTATUS return type annotation to lambda for type clarity |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So we can use something smarter than a plain NTSTATUS as a return type.