-
Notifications
You must be signed in to change notification settings - Fork 6
Bump Robolectric dependency to 4.16 #141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: utzcoz <[email protected]>
The minimum supported SDK of this version is 23. Signed-off-by: utzcoz <[email protected]>
WalkthroughUpdated dependency versions in gradle version catalog: androidMinimumSdk bumped from 19 to 21 and robolectric upgraded from 4.14.1 to 4.16. Test assertions updated to reflect the new Android M SDK level instead of LOLLIPOP. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi @warnyul, PTAL. |
|
I also reading some files of this project, and looks like they are made as the downstream extension of junit runner and sandbox. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
gradle/libs.versions.toml (1)
7-7: Confirm intendedandroidMinimumSdkin light of Robolectric 4.16’s min API 23Robolectric 4.16 now only supports running tests from Android M (API 23) upwards and drops 21/22. Bumping
robolectric = "4.16"here is correct, butandroidMinimumSdkwas only raised to"21", while the PR description mentions a minimum supported SDK of 23.If your goal is for this project’s documented minimum Android SDK to align with Robolectric’s minimum, consider bumping to 23; if you deliberately want to keep the library usable on 21/22 while tests run against 23, then the current value is fine but should be a conscious choice.
Possible change if you decide to align them:
-androidMinimumSdk = "21" +androidMinimumSdk = "23"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
gradle/libs.versions.toml(2 hunks)robolectric-extension/src/test/kotlin/tech/apter/junit/jupiter/robolectric/RobolectricExtensionCustomAndroidSdkSelfTest.kt(2 hunks)
🔇 Additional comments (1)
robolectric-extension/src/test/kotlin/tech/apter/junit/jupiter/robolectric/RobolectricExtensionCustomAndroidSdkSelfTest.kt (1)
15-43: Tests correctly updated to target SDK 23 (Android M)Using
@Config(sdk = [Build.VERSION_CODES.M])and assertingSDK_INTplusRELEASE == "6.0.1"in the outer and nested tests matches Robolectric 4.16’s new supported range (M and above) while preserving the original intent of verifying shared SDK and class loader across nested classes. Looks good.
Summary by CodeRabbit